Re: [PATCH] iSeries virtual disk

From: Christoph Hellwig (hch_at_infradead.org)
Date: 02/27/04

  • Next message: Ingo Oeser: "Re: Why no interrupt priorities?" 
    Date:	Fri, 27 Feb 2004 11:32:02 +0000
To: Stephen Rothwell <sfr@canb.auug.org.au>

    > > it to the maximum value and then reset it in a magic even handler?
    > > I think that logic needs some clarification.
    >
    > The "magic event handler" is synchronous with the probe_disk routine. I
    > agree it is a bit confusing, but, at least I have the comment there about
    > the side effects of the probe_disk routine. Changed slightly.

    The code that is in Linus' tree is still b0rked:

     - you set viodasd_max_disk in viodasd_open which looks completely bogus:
        o the value is never used after module_init, and as long as module_init
          and blkdev ->open under BKL they are serialized.
        o even if they weren't you wouldn't ever get an open call for a device
    > viodasd_max_disk
        o that means if you actually got there it would either be the same or
          decreased
        o if it was decreased in parallel to module_init your loop in
          module_init would be totally screwed.
      - now to that loop in module_init:
        o they only thing that it actually archives is that it breaks out of
          the loop if a probe_disk fails - but you could archive that much
          more easier by just returning an error from the probe_disk and
          use a break out of the loop. The >= MAX_DISKNO check could then
          easily happen on the i used as loop counter.

    > > for lowend configurations (remember we have a 32bit dev_t now)
    >
    > Can I leave this for now?

    It's really awkwards. And IBM will most likely want lots of disks soon
    anyway :)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Ingo Oeser: "Re: Why no interrupt priorities?"

    Relevant Pages

    • wait_event and preemption in 2.6
      ... I'm writing a device driver for PPC Linux and I'm using wait_event. ... preemption is turned on. ... check the condition and break out of the loop. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] NULL pointer deref in tcp_do_twkill_work()
      ... Shouldn't the loop always restart from the beginning instead of using the ... The alternative is to not drop the lock, but I'm guessing we need to do ... Proposed patch is attached. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • x86 build issue with software suspend code
      ... collision and the relocation from and alloc section targeting targeting ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.6.9-rc2-mm1 0/2] mm: memory policy for page cache allocation
      ... Patches done with the 'diff -p' option are slightly easier to ... Could you explain the for loop in alloc_page_roundrobin? ... pseudo-uniform distribution, without any need for the additional rr_next ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Fw: x86 build issue with software suspend code
      ... since otherwise problems with this code path should have been ... > incorrectly line wrapped) patch changes the attributes of the section to ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)