kgdb: fix kgdbeth compilation and make it init late enough

From: Pavel Machek (pavel_at_ucw.cz)
Date: 03/02/04

  • Next message: Wojciech 'Sas' Cieciwa: "[SPARC][patch] sys_ioperm"
    Date:	Tue, 2 Mar 2004 12:25:00 +0100
    To: "Amit S. Kale" <akale@users.sourceforge.net>, kernel list <linux-kernel@vger.kernel.org>
    
    

    Hi!

    CONFIG_NO_KGDB_CPUS can not be found anywhere in the patches => its
    probably not needd any more. init_kgdboe can't be module_initcall; in
    such cases it initializes after tg3 network card (and that's bad).

    Okay to commit?
                                                                    Pavel

    --- clean-mm/drivers/net/kgdb_eth.c 2004-03-01 22:03:55.000000000 +0100
    +++ linux-mm/drivers/net/kgdb_eth.c 2004-03-01 23:00:07.000000000 +0100
    @@ -157,15 +157,6 @@
     
     static int init_kgdboe(void)
     {
    -#ifdef CONFIG_SMP
    - if (num_online_cpus() > CONFIG_NO_KGDB_CPUS) {
    - printk
    - ("kgdb: too manu cpus. Cannot enable debugger with more than %d cpus\n",
    - CONFIG_NO_KGDB_CPUS);
    - return -1;
    - }
    -#endif
    -
             if (!np.remote_ip || netpoll_setup(&np))
                     return 1;
     
    @@ -176,4 +167,4 @@
             return 0;
     }
     
    -module_init(init_kgdboe);
    +late_initcall(init_kgdboe); /* This needs to be done after netcard is initialized */

    -- 
    When do you have a heart between your knees?
    [Johanka's followup: and *two* hearts?]
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Wojciech 'Sas' Cieciwa: "[SPARC][patch] sys_ioperm"

    Relevant Pages

    • Re: kgdb: fix kgdbeth compilation and make it init late enough
      ... >> Okay to commit? ... When do you have a heart between your knees? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: swsusp with highmem, testing wanted
      ... static int pfn_is_nosave ... static void free_suspend_pagedir_zone(struct zone *zone, ... When do you have a heart between your knees? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Help port swsusp to ppc.
      ... -static void drivers_resume ... static int suspend_prepare_image ... When do you have a heart between your knees? ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [PATCH] Fix ext3 warning for unused var
      ... Introduced in commit ... static int ext3_show_options(struct seq_file *seq, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] Fix ext3 warning for unused var
      ... Introduced in commit ... static int ext3_show_options(struct seq_file *seq, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)