Re: parport compile error in 2.6.4-r2c (sparc64)

From: Andrew Morton (akpm_at_osdl.org)
Date: 03/04/04

  • Next message: Andrew Morton: "Re: [PATCH] 2.6.4-rc2: scripts/modpost.c" 
    Date:	Thu, 4 Mar 2004 03:52:07 -0800
To: Meelis Roos <mroos@linux.ee>

    Meelis Roos <mroos@linux.ee> wrote:
    >
    > drivers/parport/parport_sunbpp.c: In function `init_one_port':
    > drivers/parport/parport_sunbpp.c:338: warning: passing arg 2 of `request_irq' from incompatible pointer type
    > drivers/parport/parport_sunbpp.c: In function `parport_sunbpp_exit':
    > drivers/parport/parport_sunbpp.c:387: error: incompatible type for argument 1 of `list_empty'

    Does this fix?

    diff -puN drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix drivers/parport/parport_sunbpp.c
    --- 25/drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix 2004-03-04 03:49:57.000000000 -0800
    +++ 25-akpm/drivers/parport/parport_sunbpp.c 2004-03-04 03:50:48.000000000 -0800
    @@ -44,9 +44,11 @@
     #define dprintk(x)
     #endif
     
    -static void parport_sunbpp_interrupt(int irq, void *dev_id, struct pt_regs *regs)
    +static irqreturn_t parport_sunbpp_interrupt(int irq, void *dev_id,
    + struct pt_regs *regs)
     {
             parport_generic_irq(irq, (struct parport *) dev_id, regs);
    + return IRQ_HANDLED;
     }
     
     static void parport_sunbpp_disable_irq(struct parport *p)
    @@ -384,7 +386,7 @@ static int __init parport_sunbpp_init(vo
     
     static void __exit parport_sunbpp_exit(void)
     {
    - while (!list_empty(port_list)) {
    + while (!list_empty(&port_list)) {
                     Node *node = list_entry(port_list.next, Node, list);
                     struct parport *p = node->port;
                     struct parport_operations *ops = p->ops;

    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Andrew Morton: "Re: [PATCH] 2.6.4-rc2: scripts/modpost.c"

    Relevant Pages

    • Re: a few issues with events
      ... have an event that, in one of its handlers, unsubscribes from another ... I coded a short test application just to be sure, and sure enough I can unsubscribe from the event I'm handling. ... static event EventHandler eventTest; ... static void OnTest() ...
      (microsoft.public.dotnet.languages.csharp)
    • Re: [PATCH] PCI fixes for 2.6.9
      ... Change for loops with list_for_each. ... static void __init ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] input/gameport/cs461x.c: make 2 functions static
      ... +static int __init cs461x_init ... +static void __exit cs461x_exit ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [RESEND] [PATCH 5/7] ppc: remove cli()/sti() in arch/ppc/platforms/pal4_setup.c
      ... Replace cli() function calls with local_irq_disablein shutdown/restart code. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] modular anslcd
      ... +static int __init ... +static void __exit ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)