Re: [2.6.4-rc2] bogus semicolon behind if()

From: Philippe Elie (phil.el_at_wanadoo.fr)
Date: 03/10/04

  • Next message: Jett Tayer: "Darren's ipfilter ported to linux" 
    Date:	Wed, 10 Mar 2004 06:08:04 +0000
To: Thomas Schlichter <thomas.schlichter@web.de>

    On Tue, 09 Mar 2004 at 12:08 +0000, Thomas Schlichter wrote:

    > As I wrote a few days ago I have problems with that ChangeSet,
    > (http://marc.theaimsgroup.com/?l=linux-kernel&m=107840458123059&w=2)
    > so I did examine it closer.

    errmm, http://tinyurl.com/2jbe4

    Maciej, you wrote this patch, any comment ?

    > so I did examine it closer.
    >
    > My results are:
    > 1. The semicolons behind the if()'s cannot be there intentionally.
    > 2. To fix my problem, timer_ack must be set to 1 for my (integrated) APIC, and
    > as my CPU has a TSC, this cannot be correct for me:
    > - timer_ack = 1;
    > + if (nmi_watchdog == NMI_IO_APIC && !APIC_INTEGRATED(ver))
    > + timer_ack = 1;
    > + else
    > + timer_ack = !cpu_has_tsc;

    I don't get the figure, this code in check_timer() is called by
    setup_IO_APIC so APIC_INTEGRATED(ver) is always 0 ?

    > I changed that if(...) to
    > if (nmi_watchdog == NMI_IO_APIC || APIC_INTEGRATED(ver))
    > which works fine for me here, but I am not 100% sure if this is what the
    > author of the original patch ment and if it still fixes the original
    > problem...
     

    regards,
    Phil

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jett Tayer: "Darren's ipfilter ported to linux"

    Relevant Pages

    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.0-test8/test9 io scheduler needs tuning?
      ... interactivity with regard to desktop use. ... Going to improve the time info output of the ddd loops to get better data and ... with the patch the hang reported earlier was not encountered again so ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
      ... > For VISWS I think you actually need to turn paging off explicitly. ... The patch will need a few tweaks but it should be fairly straight forward. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] clarify message and give support contact for non-GPL modules
      ... The author of the second module ... So here is another attempt at the patch. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)