Re: 2.6.5-rc1-mm1

From: Andrew Morton (akpm_at_osdl.org)
Date: 03/23/04

  • Next message: Paul Jackson: "Re: [PATCH] Introduce nodemask_t ADT [0/7]" 
    Date:	Mon, 22 Mar 2004 19:35:02 -0800
To: piotr@larroy.com

    piotr@larroy.com (Pedro Larroy) wrote:
    >
    > On Mon, Mar 22, 2004 at 07:33:27AM -0800, Andrew Morton wrote:
    > > piotr@larroy.com (Pedro Larroy) wrote:
    > > >
    > > > Where would kernel leaked ram be accounted?
    > >
    > > /proc/meminfo, /proc/vmstat and /proc/slabinfo. Also sysrq-M.

    A memory leak was introduced in the ext3 changes.

     25-akpm/fs/jbd/commit.c | 8 ++++++++
     1 files changed, 8 insertions(+)

    diff -puN fs/jbd/commit.c~jbd-move-locked-buffers-leak-fixes fs/jbd/commit.c
    --- 25/fs/jbd/commit.c~jbd-move-locked-buffers-leak-fixes 2004-03-22 19:34:37.492865816 -0800
    +++ 25-akpm/fs/jbd/commit.c 2004-03-22 19:34:41.987182576 -0800
    @@ -296,6 +296,13 @@ write_out_data:
                     }
             }
     
    + if (bufs) {
    + spin_unlock(&journal->j_list_lock);
    + ll_rw_block(WRITE, bufs, wbuf);
    + journal_brelse_array(wbuf, bufs);
    + spin_lock(&journal->j_list_lock);
    + }
    +
             /*
              * Wait for all previously submitted IO to complete.
              */
    @@ -322,6 +329,7 @@ write_out_data:
                             jh->b_transaction = NULL;
                             jbd_unlock_bh_state(bh);
                             journal_remove_journal_head(bh);
    + put_bh(bh);
                     } else {
                             jbd_unlock_bh_state(bh);
                     }

    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Paul Jackson: "Re: [PATCH] Introduce nodemask_t ADT [0/7]"

    Relevant Pages

    • Re: OpenSSHD Server
      ... Is there memory leak issues with sshd or, ... there is a maintenance that needs to be performed? ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)
    • Re: memory problem
      ... browsing web forums after 30 mins. Switching to other browsers helps ... to reduce my system load. ... That most likely is a memory leak with the application. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • [PATCH 29/44] HID quirk (badpad) for NEC gamepad
      ... Add a NEC USB gamepad to badpad blacklist. ... files changed, 4 insertions(+) ... struct hid_blacklist { ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 35/44] HID quirk (badpad) for Chic gamepad
      ... Add a Chic gamepad into badpad quirk list. ... files changed, 4 insertions(+) ... struct hid_blacklist { ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 26/47] when probing for ImExPS/2 mice, the ImPS/2 sequence needs to be sent first
      ... when probing for ImExPS/2 mice, the ImPS/2 sequence needs ... files changed, 2 insertions(+) ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)