Re: BUG_ON(!cpus_equal(cpumask, tmp));

From: Paul Jackson (pj_at_sgi.com)
Date: 04/01/04

  • Next message: Paul Jackson: "Re: [PATCH] mask ADT: simplify a couple cpumask uses [8/22]"
    Date:	Thu, 1 Apr 2004 00:42:51 -0800
    To: hari@in.ibm.com
    
    

    Hari,

    I see code similar to what you are changing, also in the file:

            arch/x86_64/kernel/smp.c

    Do your considerations apply here as well?

    ===

    static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm,
                                                    unsigned long va)
    {
            cpumask_t tmp;
            /* ... */
            BUG_ON(cpus_empty(cpumask));
            cpus_and(tmp, cpumask, cpu_online_map);
            BUG_ON(!cpus_equal(tmp, cpumask));
            BUG_ON(cpu_isset(smp_processor_id(), cpumask));
            if (!mm)
                    BUG();
            /* ... */

    -- 
                              I won't rest till it's the best ...
                              Programmer, Linux Scalability
                              Paul Jackson <pj@sgi.com> 1.650.933.1373
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Paul Jackson: "Re: [PATCH] mask ADT: simplify a couple cpumask uses [8/22]"

    Relevant Pages

    • Re: XFS breakage in 2.6.18-rc1
      ... system disk too who had to take the hit. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: How to run an a.out file in a kernel module
      ... called in a kernel module using call_usermodehelper ... Please read the FAQ at http://www.tux.org/lkml/ ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: XFS Bug null pointer dereference in xfs_free_ag_extent
      ... I also filed bug 6877 at kernel.org ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [patch] remove unused acct variables from task_struct
      ... struct mempolicy *mempolicy; ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: DIPC alpha2 for i386, Alpha, SPARC, and M68k
      ... there seems to be a delay on cs.uwindsor.ca between the time you upload something and the time it actually shows up on the page. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)