Re: swsusp update: supports discontingmem/highmem

From: Nigel Cunningham (ncunningham_at_users.sourceforge.net)
Date: 04/06/04

  • Next message: Rusty Russell: "Re: [PATCH] Drop exported symbols list if !modules" 
    To: Pavel Machek <pavel@ucw.cz>
Date:	Tue, 06 Apr 2004 08:24:28 +1000

    Hi.

    On Tue, 2004-04-06 at 07:23, Pavel Machek wrote:
    > + if (PageReserved(page)) {
    > + printk("highmem reserved page?!\n");
    > + BUG();
    > + }

    We dealt with this recently in suspend2. It's perfectly valid to have a
    Reserved Highmem page. They need to be completely ignored, and whatever
    driver is responsible for the memory should handle any required state
    persistance. We're setting NoSave for such pages in the parsing of the
    e820 table at boot time.

    > + if (!save)
    > + panic("Not enough memory");

    Can't you back out nicely if you don't have enough memory for the image?

    > + if (!save->data)
    > + panic("Not enough memory");

    (Ditto)
     
    > + /* Fixme: this is too late; we should do this ASAP to avoid "infinite reboots" problem */

    Fully agree. I've been meaning to do this too.

    Regards,

    Nigel 

    -- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)
Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Rusty Russell: "Re: [PATCH] Drop exported symbols list if !modules"

    Relevant Pages

    • Re: [patch] VM accounting change
      ... > memory for extensive dma (the bttv driver had always been pointed to ... pretty much a pagecache concept rather than an MM concept. ... leave the thing alone - some device driver owns the page and knows how to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.6.3-rc1
      ... > End of assembler dump. ... I think the problem is that memory used by ... previously registered ide_pci_host_proc_list entry (for pdc202xx_new driver) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Broadcom 4401 problem
      ... Interesting that it runs out of memory though. ... > The Broadcom Linux driver version 3.0.7 also locks up on me, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc2-mm1 swsusp bug report.
      ... > Nigel Cunningham wrote: ... by this stage it looks like memory is already pretty well shrunk ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.4.24 eth0: TX underrun, threshold adjusted.
      ... memory which evidently, isn't that good. ... it's the eepro100 driver that prints the messages. ... > | start sending the packet out before it's fully transferred from main ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)