Re: [PATCH] fix tuntap oversight

From: Jeremy Martin (martinjd_at_csc.uvic.ca)
Date: 04/12/04

  • Next message: David Brownell: "[patch/RFT 2.4.26-rc2] update usbnet matching 2.6.recent" 
    Date:	Mon, 12 Apr 2004 09:29:16 -0700
To: "David S. Miller" <davem@redhat.com>

    On Mon, Apr 12, 2004 at 12:15:51AM -0700, David S. Miller wrote:
    >
    > This netif_running() check is not necessary, and in fact
    > wrong.
    >
    > In fact, if ethernet drivers erroneously do this, this causes
    > them to fail to support the ALB bonding driver modes which
    > require on-the-fly MAC address changes while the interface is
    > up.
    >

    I just took a look in drivers/net/
    and
            acenic.c
            atarilance.c
            b44.c
            cs89x0.c
            net_init.c
            typhoon.c

    all use that netif_running() check when setting the MAC. I actually just pulled
    the function from net_init.c for the tun change. Are these broken?
    (I'm asking in total ignorance so be gentle :).

    -Jeremy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: David Brownell: "[patch/RFT 2.4.26-rc2] update usbnet matching 2.6.recent"

    Relevant Pages