arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build

From: Paul Jackson (pj_at_sgi.com)
Date: 04/27/04

  • Next message: Keith Owens: "[patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks" 
    Date:	Mon, 26 Apr 2004 18:56:33 -0700
To: Andrew Morton <akpm@osdl.org>, John Reiser <jreiser@BitWagon.com>, mike@navi.cx, pageexec@freemail.hu

    Not sure how (no lkml thread that I can see), but it seems from Andrew's
    broken out patch "bssprot.patch" in 2.6.6-rc2-mm2 that John Reiser
    and/or others on the To list above conspired to break the build of
    arch/ia64/ia32/binfmt_elf32.c: elf32_map().

    They added a patch that amongst other things, did:

    - elf_map(): new parameter total_size allows for holes between PT_LOAD; in
      fs/binfmt_elf.c, arch/x86_64/ia32/ia32_binfmt.c, arch/s390/kernel/
      binfmt_elf32.c.

    but they didn't change (note elf32_map is just elf_map, via a #define) this:

    ===== arch/ia64/ia32/binfmt_elf32.c 1.22 vs edited =====
    223c223
    < elf32_map (struct file *filep, unsigned long addr, struct elf_phdr *eppnt, int prot, int type) 

    ---
> elf32_map (struct file *filep, unsigned long addr, struct elf_phdr const *eppnt, int prot, int type, unsigned long total_size)
If I make the above function signature change, I can at least recompile
arch ia64 with CONFIG_IA32_SUPPORT enabled.  But I doubt that this is
ideal - as it is making no use of the new 'total_size' parameter.
Would someone care to recommend a proper fix?
-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Keith Owens: "[patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"

    Relevant Pages

    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
      ... > For VISWS I think you actually need to turn paging off explicitly. ... The patch will need a few tweaks but it should be fairly straight forward. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] clarify message and give support contact for non-GPL modules
      ... The author of the second module ... So here is another attempt at the patch. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: [PATCH 4/5] random periodicity detection fix
      ... >> WAY overestimating input entropy. ... > My patch did the opposite of your patch: ... 5/5 is a step in that direction, but the filtering is ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)