Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks
From: Benjamin Herrenschmidt (benh_at_kernel.crashing.org)
Date: 04/27/04
- Previous message: Frederick, Fabian: "Pre vfs level bootlog"
- In reply to: Keith Owens: "[patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Next in thread: Keith Owens: "Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Reply: Keith Owens: "Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Keith Owens <kaos@sgi.com> Date: Tue, 27 Apr 2004 16:54:11 +1000
> +#ifdef __HAVE_ARCH_RAW_SPIN_LOCK_FLAGS
> +#define _raw_spin_lock(lock) _raw_spin_lock_flags(lock, 0)
> +#else
> +#define _raw_spin_lock_flags(lock, flags) do { (void)flags; _raw_spin_lock(lock); } while(0)
> +#endif
Looks good, except as paulus noted that using 0 for flags in the
_raw_spin_lock() case is wrong, since 0 is a valid flags value
for some archs that could mean anything...
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Frederick, Fabian: "Pre vfs level bootlog"
- In reply to: Keith Owens: "[patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Next in thread: Keith Owens: "Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Reply: Keith Owens: "Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
