Re: 1352 NUL bytes at the end of a page? (was Re: Assertion `s && s->tree' failed: The saga continues.)

From: Andrea Arcangeli (andrea_at_suse.de)
Date: 05/16/04

  • Next message: Andrew Morton: "Re: [PATCH][1/7] perfctr-2.7.2 for 2.6.6-mm2: core" 
    Date:	Sun, 16 May 2004 07:22:20 +0200
To: Linus Torvalds <torvalds@osdl.org>

    On Sat, May 15, 2004 at 09:52:50PM -0700, Linus Torvalds wrote:
    >
    >
    > On Sat, 15 May 2004, Steven Cole wrote:
    > >
    > > OK, will do. I ran the bk exerciser script for over an hour with 2.6.6-current
    > > and no CONFIG_PREEMPT and no errors. The script only reported one
    > > iteration finished, while I got it to do 36 iterations over several hours earlier
    > > today (with a 2.6.3-4mdk vendor kernel)
    >
    > Hmm.. Th ecurrent BK tree contains much of the anonvma stuff, so this
    > might actually be a serious VM performance regression. That could
    > effectively be hiding whatever problem you saw.
    >
    > Andrea: have you tested under low memory and high fs load? Steven has 384M
    > or RAM, which _will_ cause a lot of VM activity when doing a full kernel
    > BK clone + undo + pull, which is what his test script ends up doing...

    An easy way to verify for Steven is to give a quick spin to 2.6.5-aa5
    and see if it's slow too, that will rule out the anon-vma changes
    (for completeness: there's a minor race in 2.6.5-aa5 fixed in my current
    internal tree, I posted the fix to l-k separately, but you can ignore
    the fix for a simple test, it takes weeks to trigger anyways and you
    need threads to trigger it and I've never seen threaded version control
    systems so I doubt BK is threaded).

    In general a "slowdown" cannot be related to anon-vma (unless it's a
    minor merging error), that's a black and white thing, it doesn't touch
    the vm heuristics and it will only speed the fast paths up plus it will
    save some tons of ram in the big systems. Pratically no change should be
    measurable on a small system (unless it uses an heavy amount of cows, in
    which case it will improve things, it should never hurt). As for being
    tested, it is very well tested on the small desktops too. Probably the
    only thing to double check is that there was no minor merging error that
    could have caused this.

    > It would be good to test going back to the kernel that saw the "immediate
    > problem", and try that version without CONFIG_PREEMPT.

    Agreed.

    Thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Andrew Morton: "Re: [PATCH][1/7] perfctr-2.7.2 for 2.6.6-mm2: core"

    Relevant Pages

    • Re: 2.6.0: Badness in pci_find_subsys!!
      ... > the interrupt side while something else is hotplugging a new device into ... I try to stick w/ Linus' tree, but I'll attempt to decipher the changelogs on ... It takes 47 muscles to frown, but only 4 to pull the trigger of a finely tuned ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: bk commits and dates
      ... > would be nice if it was possible, when you pull a bk tree, to have the ... either - it doesn't trigger as anything special. ... is special (in that it says when a commit hit the public tree), ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: kgdb for mainline kernel: core-lite [patch 1/3]
      ... This feature lets gdb hook onto a kernel function to detect loading and ... unloading of modules and preserves module section information for later use ... The one in my tree also apparently works to some ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [RFC] removal of legacy cdrom drivers (Re: [PATCH] mcdx.c insanity removal)
      ... bar and baz and fairly long expressions. ... if we want to keep the FPOS in the tree. ... Driver is obviously ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [BK] upgrade will be needed
      ... > tree. ... automatic real-time gateway with no license problems. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)