I would like to see ReiserFS V3 enter a feature freeze real soon.

From: Hans Reiser (reiser_at_namesys.com)
Date: 05/31/04

  • Next message: Linus Torvalds: "Re: Linux 2.6.7-rc2" 
    Date:	Mon, 31 May 2004 09:48:00 -0700
To: Chris Mason <mason@suse.com>

    While I like and appreciate the data journaling stuff, and I think it
    should go in, real soon now I think we should avoid adding new features
    to V3. Let the mission critical server folks have a reiserfs version
    that only gets bug fixes added to it, and let V4 be for those who want
    excitement.

    Are there any things which Chris and Jeff think should go in besides
    data journaling/ordering and bitmap algorithm changes?

    Also, I would like to see some serious benchmarks of the bitmap
    algorithm changes before they go in. They seem nice in theory, and some
    users liked them for their uses, but that does not make a serious
    scientific study. Such a study has a high chance of making them even
    better.;-)

    zam, I view you as the block allocator maintainer, please review that
    bitmap code from Chris.

    Chris and Jeff, can you propose a benchmarking plan for the bitmap code?

    Hans

    Chris Mason wrote:

    >On Fri, 2004-05-28 at 09:27, Vladimir Saveliev wrote:
    >
    >
    >
    >>>The good news is that we tracked this one down recently. 2.6.7-rc1
    >>>shouldn't do this anymore.
    >>>
    >>>
    >>>
    >>Just out of curiosity, what was it?
    >>
    >>
    >
    >It was a bug in reiserfs_file_write caused by the data=ordered changes.
    >I was dropping i_sem before changing i_size, and the result was that
    >writepage was zeroing out bytes it thought was past the end of the file.
    >
    >See the recent thread with "1352 NUL bytes at the end of a page?" in the
    >subject. The funny part was that we started getting bug reports for
    >this on the suse kernel just a few days before Steven Cole reported it,
    >so I was able to overlap some of the bug hunting/testing.
    >
    >-chris
    >
    >
    >
    >
    >
    >
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Linus Torvalds: "Re: Linux 2.6.7-rc2"