Re: two patches - request for comments

From: Greg KH (greg_at_kroah.com)
Date: 06/04/04

  • Next message: Greg KH: "Re: Sysfs maintainer" 
    Date:	Fri, 4 Jun 2004 13:43:22 -0700
To: Andrew Zabolotny <zap@homelink.ru>, Todd Poynor <tpoynor@mvista.com>, linux-kernel@vger.kernel.org

    On Wed, Jun 02, 2004 at 10:32:19PM +0100, Russell King wrote:
    > On Wed, Jun 02, 2004 at 10:15:42AM -0700, Greg KH wrote:
    > > On Wed, Jun 02, 2004 at 01:00:36AM +0400, Andrew Zabolotny wrote:
    > > >
    > > > In theory, if we would use the standard power interface, it could use the
    > > > different levels of power saving, e.g. 0 - controller and LCD on, 1,2 - LCD
    > > > off, controller on, 3,4 - both off.
    > >
    > > Please use the standard power interface, and use the standard levels of
    > > power state. That's why we _have_ this driver model in the first
    > > place...
    >
    > It /doesn't/ make any sense to in this case. We're talking effectively
    > about the LCD panel attributes, not a device as such.

    <snip>

    > Hope this provides some extra reasoning why using the device model
    > for these attributes is wrong.

    Ok, this makes more sense now, thanks for explaining it.

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg KH: "Re: Sysfs maintainer"