Re: sys_gettimeofday racy or not?

From: Chris Friesen (cfriesen_at_nortelnetworks.com)
Date: 06/25/04

  • Next message: Guillaume Thouvenin: "[Patch] Enhanced Linux System Accounting for 2.6.7"
    Date:	Fri, 25 Jun 2004 00:53:04 -0400
    To: Wichert Akkerman <wichert@wiggy.net>
    
    

    Wichert Akkerman wrote:
    > This just happened to catch my eye and it's probably perfectly
    > valid, but if so please educate me on why it is. In kernel/time.c
    > sys_gettimeofday() there is this code:
    >
    > if (unlikely(tz != NULL)) {
    > if (copy_to_user(tz, &sys_tz, sizeof(sys_tz)))
    > return -EFAULT;
    > }
    >
    > what prevents sys_tz from being changed while this code runs?

    Nothing at all.

    I suspect most people don't worry about it, since its use is deprecated. The
    man page for gettimeofday() says "The use of the timezone struct is obsolete".

    Chris
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Guillaume Thouvenin: "[Patch] Enhanced Linux System Accounting for 2.6.7"

    Relevant Pages

    • sys_gettimeofday racy or not?
      ... This just happened to catch my eye and it's probably perfectly ... but if so please educate me on why it is. ... Wichert Akkerman It is simple to make things. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFD: Kernel release numbering
      ... > start hammering it." ... out to a beta version even though they had a seperate beta test. ... Wichert Akkerman It is simple to make things. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Patch] Support UTF-8 scripts
      ... > atoms of the language, when there's not even a platform independent way ... Wichert Akkerman It is simple to make things. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Allow /dev/{,k}mem to be disabled to prevent kernel from being modified easily
      ... > problem with sigsegv is that it does not allow legitimate programs to choose ... > an alternate approach - the log entry would be nice though. ... Wichert Akkerman It is simple to make things. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: OT: Why is usb data many times the cpu hog that firewire is?
      ... > burgular alarm source considerably less than practical since the ... motion by analyzing the compressed datastream. ... Wichert Akkerman It is simple to make things. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)