Re: drivers/block/ub.c

From: Oliver Neukum (oliver_at_neukum.org)
Date: 06/27/04

  • Next message: Oliver Neukum: "Re: drivers/block/ub.c" 
    To: "David S. Miller" <davem@redhat.com>
Date:	Sun, 27 Jun 2004 00:36:14 +0200

    Am Sonntag, 27. Juni 2004 00:07 schrieb David S. Miller:
    > On Sat, 26 Jun 2004 23:56:49 +0200
    > Oliver Neukum <oliver@neukum.org> wrote:
    >
    > > Unless I am mistaken, this structure is transfered as such over the bus,
    > > so IMHO here it is needed.
    >
    > That is not the only criterious that needs to be met in order for
    > the packed attribute to be required.
    >
    > It is needed only if the structure elements are such that gcc will
    > not packet them properly on all supported architecutures. Peter's
    > example in his code will be packed properly without the packed
    > attribute to the best of my knowledge.

    So either it has no effect or it is needed?
    Then why take the risk that gcc is changed or an architecture added that
    needs it? It seems to be cleaner to me to mark data structures that
    must be layed out as specified specially. Safer, too, just in case.

            Regards
                    Oliver
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Oliver Neukum: "Re: drivers/block/ub.c"

    Relevant Pages

    • Re: [PATCH] Fix NR_KEYS off-by-one error
      ... > larger types (short or int, ... Probably gcc not warn, I think. ... > You are absolutely correct that overhead is insignificant. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • oops when copying from IDE CD
      ... gcc version 3.3.2 20030908 ... I haven't got any experience in reporting kernel panics, ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: Problems Building Bluetooth with K6 and CONFIG_REGPARM
      ... >>Hi Andy, ... > Sounds like a compiler bug, especially since changing the CPU type fixes ... I was using Debian's GCC 4.0.1-6. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.6-rc3: gcc 2.95: cx88 __ucmpdi2 error
      ... > the switch in set_tvaudio. ... It might help to use "objdump" to disassemble the object file and see ... slower and bigger code, it's historically been pretty buggy in gcc, so ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 12/39] NLKD/i386 - time adjustment
      ... The patch includes code that seems to imply that gcc can not do mpy of variables. ... I really do not see the relavence of the run time library patches given the above. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)