[PATCH] ide-taskfile.c fixups/cleanups part #2 [2/9]

From: Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz_at_elka.pw.edu.pl)
Date: 06/30/04

  • Next message: Bartlomiej Zolnierkiewicz: "[PATCH] ide-taskfile.c fixups/cleanups part #2 [7/9]"
    To: linux-ide@vger.kernel.org
    Date:	Wed, 30 Jun 2004 17:24:22 +0200
    
    

    [PATCH] ide: PIO-out ->prehandler() fixes (CONFIG_IDE_TASKFILE_IO=y)

    Setup handler and output first data block directly from ->prehandler()
    instead of calling ->handler(). The only change in functionality is that
    we no longer check DRIVE_READY status bits (there is no need to do it).

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>

     linux-2.6.7-bk11-bzolnier/drivers/ide/ide-taskfile.c | 10 ++++++++--
     1 files changed, 8 insertions(+), 2 deletions(-)

    diff -puN drivers/ide/ide-taskfile.c~ide_tf_pio_out_prehandler drivers/ide/ide-taskfile.c
    --- linux-2.6.7-bk11/drivers/ide/ide-taskfile.c~ide_tf_pio_out_prehandler 2004-06-28 21:21:23.952054632 +0200
    +++ linux-2.6.7-bk11-bzolnier/drivers/ide/ide-taskfile.c 2004-06-28 21:21:23.957053872 +0200
    @@ -698,7 +698,10 @@ ide_startstop_t pre_task_out_intr (ide_d
             if (!drive->unmask)
                     local_irq_disable();
     
    - return task_out_intr(drive);
    + ide_set_handler(drive, &task_out_intr, WAIT_WORSTCASE, NULL);
    + task_sectors(drive, rq, 1, IDE_PIO_OUT);
    +
    + return ide_started;
     }
     EXPORT_SYMBOL(pre_task_out_intr);
     
    @@ -762,7 +765,10 @@ ide_startstop_t pre_task_mulout_intr (id
             if (!drive->unmask)
                     local_irq_disable();
     
    - return task_mulout_intr(drive);
    + ide_set_handler(drive, &task_mulout_intr, WAIT_WORSTCASE, NULL);
    + task_multi_sectors(drive, rq, IDE_PIO_OUT);
    +
    + return ide_started;
     }
     EXPORT_SYMBOL(pre_task_mulout_intr);
     

    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Bartlomiej Zolnierkiewicz: "[PATCH] ide-taskfile.c fixups/cleanups part #2 [7/9]"

    Relevant Pages

    • Re: linux: detect application crash
      ... I was curious if such a functionality ... The app itself could do this (installing a signal handler for segfaults, ... etc.) but the problem is that whatever caused the program to crash may ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: syscall: sys_promote
      ... work because functionality like fork process counting, exec, and setuid ... you fix the uid locking. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Jackit-devel] Re: [patch] voluntary-preempt-2.6.8-rc2-M5
      ... > to pollbefore entering the polling loop, by which time there has been ... internally calls malloc*after* calling snd_pcm_start. ... There's probably nothing to prevent us moving the freeand malloc() ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [discuss] Re: [Patch] x86, x86_64: Intel HT, Multi core detection code cleanup
      ... -mm tree picks up these enhancements first, ... > as separate patches the various functionality enhancements.That makes ... I am going to send two follow up patches which addresses the functionality ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] bitmap parsing/printing routines, version 4
      ... > change the functionality of the code, ... Andrew, if you do like the fully commented version, then please remove ... The dilute style of coding is ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)