Re: [2.6 patch] e1000_main.c: fix inline compile errors

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 07/15/04

  • Next message: Timothy Miller: "Dumb question about Voluntary Kernel Preemption Patch"
    Date:	Thu, 15 Jul 2004 21:46:23 +0200
    To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
    
    

    On Thu, Jul 15, 2004 at 12:13:59PM +0300, Denis Vlasenko wrote:
    >...
    > As you go thru them, consider removing inline keyword for
    > such large functions.
    >...

    I did propose this as an alternative approach in the text that
    accopagnied the patch.

    My main reason for not directly proposing to remove the inlines was the
    fact that all inline functions were either very small or called only
    once.

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Timothy Miller: "Dumb question about Voluntary Kernel Preemption Patch"

    Relevant Pages

    • Re: [PATCH 8/8] Inline 3 functions
      ... remove the inline... ... all static functions when it does make sense. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] kill IN_STRING_C
      ... > a new copy for each file in which gcc decides not to inline the function. ... leaving gcc no room for a decision to not inline it. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 8/8] Inline 3 functions
      ... How about a tag ... Why should such a function be manually marked "inline" at all? ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Cant compile sg.c 2.6.8-rc1-mm1
      ... it's an inline that is used before it's defined. ... I'll send a fix soon. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] net/ipv4/: misc possible cleanups
      ... It is needed for the ipv6 module ... tcp_clear_xmit_timers which is not an inline but an ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)