Re: Altix I/O code re-org

From: Robin Holt (holt_at_sgi.com)
Date: 07/22/04

  • Next message: Dave Kleikamp: "[ANNOUNCE] jfsutils 1.1.7" 
    Date:	Thu, 22 Jul 2004 15:20:45 -0500
To: Christoph Hellwig <hch@infradead.org>, Robin Holt <holt@sgi.com>, Jesse Barnes <jbarnes@engr.sgi.com>, Pat Gefre <pfg@sgi.com>, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org

    On Thu, Jul 22, 2004 at 08:42:31PM +0100, Christoph Hellwig wrote:
    > > PS: I found a few small problems with the bte code and will soon have
    > > another patch that fixes that up. Specifically, there were changes
    > > made to bte_error.c and pda.h that are undone by your patch.
    >
    > apropos bte, could you please merge bte_error.c into bte.c - there's no
    > external callers of functions in bte_error.c except in bte.c

    bte.c doesn't call bte_error. That used to get called from shub_iio_error()
    or something like that. Would it be more appropriate to merge bte_error.c
    into the callers file? I would lean towards putting it into bte.c, but
    your previous add implied it should go into the callers file.

    Thanks,
    Robin
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Dave Kleikamp: "[ANNOUNCE] jfsutils 1.1.7"

    Relevant Pages

    • Re: [PATCH] Bind Mount Extensions 0.04.1 3/5
      ... the few callers of vfs_permission use that one instead? ... hmm, well but how would moving the ro checks around ... or adding them for the vfs mounts influence that? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 0/4] new timeofday-based soft-timer subsystem
      ... > have made some major changes in this revision. ... we don't need to change all the callers of ... There was a bug in my ppc64 emulation (was just using jiffies not ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Use of getblk differs between locations
      ... Anton Altaparmakov wrote: ... Testing and failing ... It is appropriate at this time to fix the callers so that they correctly ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Lse-tech] Re: Hugetlbpages in very large memory machines.......
      ... retains the old interface to avoid having to update most callers. ... I don't have any fundamental problem with the nature of the change. ... a side note, patch was malformed, not sure ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: SG_IO and security
      ... > descriptor. ... If you have write access to a block device, ... Anybody willing to go through the callers? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)