-mm swsusp: fix highmem handling

From: Pavel Machek (pavel_at_ucw.cz)
Date: 07/29/04

  • Next message: Nigel Cunningham: "Re: [PATCH] Add missing refrigerator support."
    Date:	Thu, 29 Jul 2004 00:23:00 +0200
    To: Patrick Mochel <mochel@digitalimplant.org>, kernel list <linux-kernel@vger.kernel.org>
    
    

    Hi!

    Swsusp was not restoring highmem properly. I did not find a nice place
    where to restore it, through, so it went to swsusp_free.

    I'm not sure why you are saving state before
    save_processor_state. swsusp_arch_resume will overwrite this,
    anyway. Is it to make something balanced?
                                                                    Pavel

    --- clean-mm/kernel/power/swsusp.c 2004-07-28 23:39:49.000000000 +0200
    +++ linux-mm/kernel/power/swsusp.c 2004-07-28 23:30:33.000000000 +0200
    @@ -656,6 +652,10 @@
                             free_suspend_pagedir_zone(zone, p);
             }
             free_pages(p, pagedir_order);
    +#ifdef CONFIG_HIGHMEM
    + printk( "Restoring highmem\n" );
    + restore_highmem();
    +#endif
     }
     
     
    @@ -890,7 +890,6 @@
     {
             int error;
             local_irq_disable();
    - save_processor_state();
             error = swsusp_arch_resume();
             restore_processor_state();
             local_irq_enable();

    -- 
    People were complaining that M$ turns users into beta-testers...
    ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Nigel Cunningham: "Re: [PATCH] Add missing refrigerator support."

    Relevant Pages

    • swsusp fixes: fix confusing printk
      ... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: The purpose of PT_TRACESYSGOOD
      ... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • make suspend work with ioapic
      ... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] remove CONFIG_PM_DISK
      ... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: year 2038 problem on x86-64
      ... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)