-mm swsusp: copy_page is harmfull
From: Pavel Machek (pavel_at_ucw.cz)
Date: 07/29/04
- Previous message: Pavel Machek: "-mm swsusp: make sure we do not return to userspace where image is on disk"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 29 Jul 2004 00:26:45 +0200 To: Patrick Mochel <mochel@digitalimplant.org>, Andrew Morton <akpm@zip.com.au>, kernel list <linux-kernel@vger.kernel.org>
Hi!
This is my fault from long time ago: copy_page can't be used for
copying task struct, therefore we can't use it in swsusp. Please
apply,
Pavel
--- clean-mm/kernel/power/swsusp.c 2004-07-28 23:39:49.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c 2004-07-28 23:30:33.000000000 +0200
@@ -614,12 +614,8 @@
struct page * page;
page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
pbe->orig_address = (long) page_address(page);
- /* Copy page is dangerous: it likes to mess with
- preempt count on specific cpus. Wrong preempt
- count is then copied, oops.
- */
- copy_page((void *)pbe->address,
- (void *)pbe->orig_address);
+ /* copy_page is no usable for copying task structs. */
+ memcpy((void *)pbe->address, (void *)pbe->orig_address, PAGE_SIZE);
pbe++;
}
}
-- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Pavel Machek: "-mm swsusp: make sure we do not return to userspace where image is on disk"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
