Re: -mm swsusp: do not default to platform/firmware

From: Nigel Cunningham (ncunningham_at_linuxmail.org)
Date: 07/29/04

  • Next message: Philippe Gerum: "Re: [patch] IRQ threads" 
    To: Pavel Machek <pavel@ucw.cz>
Date:	Thu, 29 Jul 2004 17:52:44 +1000

    Hi.

    Sorry to do this to you - there are still a couple of errors.

    On Thu, 2004-07-29 at 17:39, Pavel Machek wrote:
    > Thanks, text is now:
    >
    > Q: Kernel thread must voluntarily freeze itself (call 'refrigerator'). But

    Q: A kernel thread ... 'refrigerator') but ...

    (Sentences shouldn't begin with 'But').

    > I found some kernel threads that don't do it, and they don't freeze, and

    the last ', and' should probably go.

    > so the system can't sleep. Is this a known behavior?

    American spelling. I'll resist the temptation!

    > A: All such kernel threads need to be fixed, one by one. Select place

    Select the place

    > where it is safe to be frozen (no kernel semaphores should be held at

    it -> the thread (the previous subject was plural).

    > that point and it must be safe to sleep there), and add:
    >
    > if (current->flags & PF_FREEZE)
    > refrigerator(PF_FREEZE);
    >
    > If the thread is needed for writing the image to storage, you should
    > instead set the PF_NOFREEZE process flag when creating the thread.
    >
    > I'll eventually push it, too.

    Thanks!

    Nigel

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Philippe Gerum: "Re: [patch] IRQ threads"

    Relevant Pages

    • Re: RFD: Kernel release numbering
      ... that if a particular development cycle drags on for some reason, ... and certain bugs never got fixed in the previous release, ... release until they do another push. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH][2.6] constant_test_bit doesnt like my gcc
      ... 0x0804832e: mov 0xfffffffc,%eax ... 0x08048337: sub $0x8,%esp ... 0x0804833e: push $0x8048400 ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: reverse engineering pwcx
      ... 640x480 = 307200 pixels ... push through a usb1.1 port. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: SATA status report updated
      ... It's been feature-complete for a while, but the reports from testers in ... the field have made me too nervous to push it into the upstream kernel. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: mremap bug and 2.4?
      ... Yeah, I have to compile a new kernel, test it and push it out ... this week to 600 machines but atleast I don't have to wait 6 months and ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)