Re: PATCH: Fix ide probe double detection

From: Doug Maxey (dwm_at_austin.ibm.com)
Date: 07/29/04

  • Next message: Jesse Barnes: "Re: [Lse-tech] [RFC][PATCH] Change pcibus_to_cpumask() to pcibus_to_node()"
    To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Date:	Thu, 29 Jul 2004 10:56:38 -0500
    
    

    On Thu, 29 Jul 2004 13:22:44 +1000, Benjamin Herrenschmidt wrote:
    >On Wed, 2004-07-28 at 08:46, Alan Cox wrote:
    >> Some devices don't decode master/slave - notably PCMCIA adapters.
    >> Unfortunately for us some also do, which makes it hard to guess if we
    >> should probe the slave.
    >>
    >> This patch fixes the problem by probing the slave and then using the model
    >> and serial information to spot undecoded pairs. An additional check is done
    >> to catch pairs of pre ATA devices just in case.
    >
    >What about checking if drive->select sticks ? And if that doesn't work,
    >something like
    >
    >- select 0
    >- write a value to reg X
    >- select 1
    >- write a different value to reg X
    >- select 0
    >- check value
    >
    >reg X could be nsect or such ...
    >
    >I don't like relying on drive->id and serial_no, but that may just be
    >paranoia...
    >
    >Ben.

    One strategy would be to reverse the order of probes, doing drive 1 first,
    then drive 0. When I was working IDE in AIX, we had some ATAPI devices that
    were recalcitrant until the strategy was switched to 1,0 order

    ++doug
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Jesse Barnes: "Re: [Lse-tech] [RFC][PATCH] Change pcibus_to_cpumask() to pcibus_to_node()"

    Relevant Pages

    • Re: PATCH: Fix ide probe double detection
      ... > should probe the slave. ... > and serial information to spot undecoded pairs. ... write a different value to reg X ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • PATCH: Fix ide probe double detection
      ... should probe the slave. ... This patch fixes the problem by probing the slave and then using the model ... and serial information to spot undecoded pairs. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: spyware or adware ?
      ... "Saurabh" wrote in message ... > Automatically when windows load it pop-ups with PORN ... > I tried all the possible way...i have detect that one reg ... > that same probe... ...
      (microsoft.public.win2000.general)
    • Re: ATA-ng
      ... ATA channel 0: ... Slave: no device present ... a Hitachi DVDROM as the slave device. ... the Plextor device did probe ...
      (freebsd-current)
    • Re: 555 Timer Question
      ... like measuring a battery with R probe to + and B probe to - and the ... next moment reversing the battery with R probe to - and B probe to + ... The change over switch makes the master spk behaves ... as a mic and the slave spk as a receiver. ...
      (sci.electronics.basics)

    Loading