Re: [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread

From: Len Brown (len.brown_at_intel.com)
Date: 07/30/04

  • Next message: Randy.Dunlap: "Re: 2.6.8-rc2 crash(s)?"
    To: Zwane Mwaikambo <zwane@fsmlabs.com>
    Date:	29 Jul 2004 23:38:07 -0400
    
    

    applied to 2.6.

    thanks Zwane.
    -Len

    On Thu, 2004-07-22 at 11:30, Zwane Mwaikambo wrote:
    > (Please apply this patch instead of the previously posted one).
    >
    > This patch addresses the following bugzilla bug;
    >
    > http://bugzilla.kernel.org/show_bug.cgi?id=1716
    >
    > When unloading the processor module we modify the currently used idle
    > thread (pm_idle), this causes an oops due to the idle thread text
    > being
    > unloaded. This should apply to both 2.6 and 2.4.
    >
    > Signed-off-by: Zwane Mwaikambo <zwane@fsmlabs.com>
    >
    > Index: linux-2.6.8-rc1-mm1/drivers/acpi/processor.c
    > ===================================================================
    > RCS file: /home/cvsroot/linux-2.6.8-rc1-mm1/drivers/acpi/processor.c,v
    > retrieving revision 1.1.1.1
    > diff -u -p -B -r1.1.1.1 processor.c
    > --- linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 14 Jul 2004
    > 04:56:25 -0000 1.1.1.1
    > +++ linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 20 Jul 2004
    > 15:31:46 -0000
    > @@ -2372,8 +2372,10 @@ acpi_processor_remove (
    > pr = (struct acpi_processor *) acpi_driver_data(device);
    >
    > /* Unregister the idle handler when processor #0 is removed.
    > */
    > - if (pr->id == 0)
    > + if (pr->id == 0) {
    > pm_idle = pm_idle_save;
    > + synchronize_kernel();
    > + }
    >
    > status = acpi_remove_notify_handler(pr->handle,
    > ACPI_DEVICE_NOTIFY,
    > acpi_processor_notify);
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Randy.Dunlap: "Re: 2.6.8-rc2 crash(s)?"

    Relevant Pages

    • Re: [CPU Hotplug PATCH] Restore Idle tasks priority during CPU_DEAD notification
      ... while your patch creates a perfectly correct ... > idle thread too, i'd prefer the modified variant below. ... Since we will have to setup the static priority everytime CPU_DEAD is ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd
      ... I hadn't seen Rusty's patch on Debian's bts, ... but that's only a problem if module unloading is also ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
      ... (Please apply this patch instead of the previously posted one). ... When unloading the processor module we modify the currently used idle ... this causes an oops due to the idle thread text being ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)