Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels

From: Andi Kleen (ak_at_suse.de)
Date: 07/30/04

  • Next message: Grega Fajdiga: "Warning in smbfs - 2.6.8-rc2-mm1"
    Date:	Fri, 30 Jul 2004 19:43:04 +0200
    To: Jeff Garzik <jgarzik@pobox.com>
    
    

    On Fri, 30 Jul 2004 13:16:28 -0400
    Jeff Garzik <jgarzik@pobox.com> wrote:

    >
    > 1) Changing from GFP_ATOMIC to <something else> may break code

    x86-64 did it for a long time and I am not aware of problems with it
    (however I don't know how widespread CONFIG_PREEMPT use on x86-64 is)

    > 2) Conversely from #1, I also worry why GFP_ATOMIC would be needed at
    > all. I code all my drivers to require that pci_alloc_consistent() be
    > called from somewhere that is allowed to sleep.

    Maybe you do, but others don't.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Grega Fajdiga: "Warning in smbfs - 2.6.8-rc2-mm1"

    Relevant Pages

    • Re: [Announce] Emulex LightPulse Device Driver
      ... On Wed, 2004-03-10 at 03:35, Jeff Garzik wrote: ... > leap to open source. ... it would be my interpretation of the FAQ that most of this ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Re: Weird... 2.6.9 kills FC2 gcc
      ... On Mon, 2004-10-18 at 23:31 -0400, Jeff Garzik wrote: ... > So this ICE appears to be a bug specific to 3.3.x or perhaps Fedora. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH]: Dont force O_LARGEFILE for 32 bit processes on ia64 - 2.6.12-rc3
      ... Jeff Garzik wrote: ... some 32-bit binaries are compiled without O_LARGEFILE ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [git patches try2] 2.6.x net driver updates
      ... On Wed, 25 May 2005, Jeff Garzik wrote: ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [ACPI] Re: [PATCH] Next round of ACPI IRQ fixes (VIA ACPI fixed)
      ... | Jeff Garzik wrote: ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)