Re: Exposing ROM's though sysfs
From: Jesse Barnes (jbarnes_at_engr.sgi.com)
Date: 07/30/04
- Previous message: Grega Fajdiga: "Warning in smbfs - 2.6.8-rc2-mm1"
- In reply to: Christoph Hellwig: "Re: Exposing ROM's though sysfs"
- Next in thread: Jesse Barnes: "Re: Exposing ROM's though sysfs"
- Reply: Jesse Barnes: "Re: Exposing ROM's though sysfs"
- Reply: Matthew Wilcox: "Re: Exposing ROM's though sysfs"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Christoph Hellwig <hch@infradead.org> Date: Fri, 30 Jul 2004 10:57:12 -0700
On Friday, July 30, 2004 10:24 am, Christoph Hellwig wrote:
> On Fri, Jul 30, 2004 at 10:10:29AM -0700, Jesse Barnes wrote:
> > + unsigned long start = dev->resource[PCI_ROM_RESOURCE].start;
> > + int size = dev->resource[PCI_ROM_RESOURCE].end -
> > + dev->resource[PCI_ROM_RESOURCE].start;
>
> pci_resource_start and pci_resource_len please.
>
> > + .name = "rom",
> > + .mode = S_IRUGO | S_IWUSR,
>
> do we really want it world readable if a read messes with pci config
> space?
>
> > + if (pdev->resource[PCI_ROM_RESOURCE].start) {
> > + pci_rom_attr.size = pdev->resource[PCI_ROM_RESOURCE].end -
> > + pdev->resource[PCI_ROM_RESOURCE].start;
>
> as above.
Oops, forgot about those macros. Fixed. I've also fixed the perms, RO by
root.
willy brings up a good point though, we may want to disable the rom file
entirely after its been read, since it can be a source of trouble. Here's
the latest patch.
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- text/plain attachment: pci-sysfs-rom-2.patch
- Previous message: Grega Fajdiga: "Warning in smbfs - 2.6.8-rc2-mm1"
- In reply to: Christoph Hellwig: "Re: Exposing ROM's though sysfs"
- Next in thread: Jesse Barnes: "Re: Exposing ROM's though sysfs"
- Reply: Jesse Barnes: "Re: Exposing ROM's though sysfs"
- Reply: Matthew Wilcox: "Re: Exposing ROM's though sysfs"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
