Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels

From: Jeff Garzik (jgarzik_at_pobox.com)
Date: 07/30/04

  • Next message: Jesse Barnes: "Re: Exposing ROM's though sysfs" 
    Date:	Fri, 30 Jul 2004 14:07:57 -0400
To: Andi Kleen <ak@suse.de>

    Andi Kleen wrote:
    > On Fri, 30 Jul 2004 13:16:28 -0400
    > Jeff Garzik <jgarzik@pobox.com> wrote:
    >
    >
    >
    >>1) Changing from GFP_ATOMIC to <something else> may break code
    >
    >
    > x86-64 did it for a long time and I am not aware of problems with it
    > (however I don't know how widespread CONFIG_PREEMPT use on x86-64 is)
    >
    >
    >>2) Conversely from #1, I also worry why GFP_ATOMIC would be needed at
    >>all. I code all my drivers to require that pci_alloc_consistent() be
    >>called from somewhere that is allowed to sleep.
    >
    >
    > Maybe you do, but others don't.

    Certainly. Therefore, changing from GFP_ATOMIC will increase likelihood
    of breakage, no?

            Jeff

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jesse Barnes: "Re: Exposing ROM's though sysfs"

    Relevant Pages

    • Re: XFS breakage in 2.6.18-rc1
      ... system disk too who had to take the hit. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: How to run an a.out file in a kernel module
      ... called in a kernel module using call_usermodehelper ... Please read the FAQ at http://www.tux.org/lkml/ ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: XFS Bug null pointer dereference in xfs_free_ag_extent
      ... I also filed bug 6877 at kernel.org ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [patch] remove unused acct variables from task_struct
      ... struct mempolicy *mempolicy; ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: DIPC alpha2 for i386, Alpha, SPARC, and M68k
      ... there seems to be a delay on cs.uwindsor.ca between the time you upload something and the time it actually shows up on the page. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)