Re: 2.6.8-rc2-mm1

From: Andrew Morton (akpm_at_osdl.org)
Date: 07/31/04

  • Next message: Andries Brouwer: "Re: uid of user who mounts" 
    Date:	Sat, 31 Jul 2004 11:47:14 -0700
To: Zwane Mwaikambo <zwane@linuxpower.ca>

    Zwane Mwaikambo <zwane@linuxpower.ca> wrote:
    >
    > Ingo i believe you have a patch for this, could you push it to Andrew?

    I suspect Ingo's patch will be livelockable under some circumstances.

    I suspect mine is too, only less so.

    > I reckon it's provoked by CONFIG_PREEMPT.

    This should fix.

    diff -puN fs/jbd/checkpoint.c~journal_clean_checkpoint_list-latency-fix-fix fs/jbd/checkpoint.c
    --- 25/fs/jbd/checkpoint.c~journal_clean_checkpoint_list-latency-fix-fix 2004-07-31 11:43:39.320530424 -0700
    +++ 25-akpm/fs/jbd/checkpoint.c 2004-07-31 11:44:11.859583736 -0700
    @@ -497,8 +497,7 @@ int __journal_clean_checkpoint_list(jour
                      * We don't test cond_resched() here because another CPU could
                      * be waiting on j_list_lock() while holding a different lock.
                      */
    - if ((ret & 127) == 127) {
    - spin_unlock(&journal->j_list_lock);
    + if (transaction && (ret & 127) == 127) {
                             /*
                              * We need to schedule away. Rotate both this
                              * transaction's buffer list and the checkpoint list to
    @@ -512,6 +511,7 @@ int __journal_clean_checkpoint_list(jour
                             if (transaction)
                                     journal->j_checkpoint_transactions =
                                             transaction->t_cpnext;
    + spin_unlock(&journal->j_list_lock);
                             return ret;
                     }
     #endif
    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Andries Brouwer: "Re: uid of user who mounts"

    Relevant Pages

    • Re: Firewire/SBP2 and the -mm tree (was: Re: 2.6.13-rc1-mm1)
      ... > Hi, Andrew. ... > fixes for the SBP2 problems that I was seeing, ... > things are equal regarding it, I need this patch for using Firewire on my ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • (no subject)
      ... > some of the RT patch was a little crazy. ... > threads (Correct me if I'm wrong Andrew). ... > I don't know to what extent Ingo has lobbied to try to get acceptance ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [ck] [PATCH] dynamic-tick patch modified for SMP
      ... > you have a different idle route (which I suspect is the case), ... here is a rolled up patch of yours on top of mine for those wanting to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFD] Explicitly documenting patch submission
      ... What if I send a patch to l-k, and Bruce forwards it on to Andrew; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Mem issues in 2.6.9 (ever since 2.6.9-rc3) and possible cause
      ... On Sat, 23 Oct 2004, Javier Marcet wrote: ... I suspect the following patch might be ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)