Re: 2.6.8-rc2-mm1

From: Ingo Molnar (mingo_at_redhat.com)
Date: 08/01/04

  • Next message: Paul Jackson: "Re: [PATCH][2.6] first/next_cpu returns values > NR_CPUS"
    Date:	Sun, 1 Aug 2004 07:16:24 -0400 (EDT)
    To: Andrew Morton <akpm@osdl.org>
    
    

    On Sat, 31 Jul 2004, Andrew Morton wrote:

    > Sorry. Try this one instead.
    >
    > --- 25/fs/jbd/checkpoint.c~journal_clean_checkpoint_list-latency-fix-fix 2004-07-31 11:43:39.320530424 -0700
    > +++ 25-akpm/fs/jbd/checkpoint.c 2004-07-31 13:20:22.562303576 -0700
    > @@ -497,8 +497,8 @@ int __journal_clean_checkpoint_list(jour
    > * We don't test cond_resched() here because another CPU could
    > * be waiting on j_list_lock() while holding a different lock.
    > */
    > - if ((ret & 127) == 127) {
    > - spin_unlock(&journal->j_list_lock);
    > + transaction = journal->j_checkpoint_transactions
    > + if (transaction && (ret & 127) == 127) {

    this should cause a crash later on - 'transaction' is also the loop
    variable here.

            Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Paul Jackson: "Re: [PATCH][2.6] first/next_cpu returns values > NR_CPUS"

    Relevant Pages

    • Re: Slow bash script
      ... getting only about one iteration per second in the while loop. ... It extracts md5sums from a 180k Packages file and makes an indices file. ... though I'm no script master, ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)
    • Re: loading huge number of rules in iptables (blocklist)
      ... Hash: SHA1 ... So the above function's loop goes over these many times ... inserting the rules for each range. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: Cracking SSL passwords for fun and profit
      ... file the current loop variables, and load them on startup if given the ... OpenSSL, it was designed _not_ to accept passwords from the ... openssh is not the only ssh client in Debian. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: iceape puzzle
      ... There's another process doing things with dpkg at the time this loop happens. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ... Trouble? ...
      (Debian-User)
    • [PATCH 9/9] Cleanup a loop in set_slab_attr()
      ... Last, but not least, fix a loop in set_slab_attrto match the rest of the ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)