[via-rhine] Really call rhine_power_init()

From: Roger Luethi (rl_at_hellgate.ch)
Date: 08/04/04

  • Next message: Duncan Sands: "Re: Oops at bttv_risc_packed (2.6.8-rc1)"
    Date:	Wed, 4 Aug 2004 11:37:09 +0200
    To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
    
    

    This is a fix for the heisenbug with via-rhine refusing to work
    sometimes. Patch "[9/9] Restructure reset code" contained a change made
    necessary by patch [8/9]. Mainline merged [8/9] for 2.6.8 and is still
    missing the fix, while -mm got it with [9/9].

    Jesper Juhl provided crucial test data when no one else was able to
    reproduce the symptoms.

    Roger

    Signed-off-by: Roger Luethi <rl@hellgate.ch>

    --- tmp/drivers/net/via-rhine.c.00_broken 2004-07-29 13:58:17.000000000 +0200
    +++ tmp/drivers/net/via-rhine.c 2004-07-30 15:12:36.656007543 +0200
    @@ -748,6 +748,8 @@ static int __devinit rhine_init_one(stru
             }
     #endif /* USE_MMIO */
             dev->base_addr = ioaddr;
    + rp = netdev_priv(dev);
    + rp->quirks = quirks;
     
             rhine_power_init(dev);
     
    @@ -792,10 +794,8 @@ static int __devinit rhine_init_one(stru
     
             dev->irq = pdev->irq;
     
    - rp = netdev_priv(dev);
             spin_lock_init(&rp->lock);
             rp->pdev = pdev;
    - rp->quirks = quirks;
             rp->mii_if.dev = dev;
             rp->mii_if.mdio_read = mdio_read;
             rp->mii_if.mdio_write = mdio_write;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Duncan Sands: "Re: Oops at bttv_risc_packed (2.6.8-rc1)"

    Relevant Pages

    • Re: [PATCH] asiliantfb fixes
      ... The below fix is missing. ... A call to the init function ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] ppc32: MV643XX ethernet is an option for Pegasos
      ... Pegasos and adds what I think is a missing ... fix from Dale's batch, that is remove SA_INTERRUPT and add SA_SHIRQ in ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] JFFS compile error
      ... When compiling JFFS as a module, set_special_pids is missing since it is ... Here is a trivial patch to fix that: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PPC64 PowerMac G5 support available
      ... > Does the appended fix it? ... since it's missing a "get_device" at the top of the loop. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc2-mm2
      ... I just had a look at mm2 and it's missing davem's latest fix in fib_hash.c: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)