Re: Solving suspend-level confusion

From: Pavel Machek (pavel_at_ucw.cz)
Date: 08/06/04

  • Next message: Adrian Bunk: "What exactly is __ALIGN_STR in pnpbios/bioscalls.c for?"
    Date:	Fri, 6 Aug 2004 23:30:34 +0200
    To: Nigel Cunningham <ncunningham@linuxmail.org>
    
    

    Hi!

    > > That's where the whole confusion is indeed... and why we need to make
    > > that clear. The IDE driver will sleep the disk for 3 and keep it spinning
    > > for 4
    >
    > Okay. So that leaves me calling device_suspend(4) when I want to quiesce
    > the driver but not spin down and device_suspend(3) when I want to power
    > down. Does that sound right? It sounds hairy to me. (Do other drivers
    > treat 3 and 4 in the same way?)

    This really needs to be cleaned up properly. What you do is pretty
    much okay, but we need to switch to enums or char * or something and
    kill the confusion.
                                                                    Pavel

    -- 
    People were complaining that M$ turns users into beta-testers...
    ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Adrian Bunk: "What exactly is __ALIGN_STR in pnpbios/bioscalls.c for?"

    Relevant Pages

    • Re: ds1620: replace schedule_timeout() with msleep()
      ... > the clarification. ... As part-author of this driver, and actually of this particular bit ... at full power in order to start running, so the idea here is to give ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ds1620: replace schedule_timeout() with msleep()
      ... >> the clarification. ... > As part-author of this driver, and actually of this particular bit ... > at full power in order to start running, so the idea here is to give ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Hotplug for device power state changes
      ... > driver managing the power state of its devices (according to some ... > implement drivers that are more actively involved in managing power ... core driver level, if you wanted to do it all. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: shuttle an50r Motherboard and Linux
      ... 2.4.x needs update of amd74xx.c driver. ... 2.6.x should be okay. ... Bartlomiej ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3
      ... > Okay, last call for comment on this driver. ... > Any other issues before initial kernel inclusion? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)