Re: Merge I2O patches from -mm

From: Markus Lidel (Markus.Lidel_at_shadowconnect.com)
Date: 08/17/04

  • Next message: Premier_lotteryuk: "LOTTERY WINNING NOTIFICATION." 
    Date:	Tue, 17 Aug 2004 15:31:18 +0200
To: Christoph Hellwig <hch@infradead.org>

    Hi...

    Christoph Hellwig wrote:
    > On Sun, Aug 15, 2004 at 12:15:40AM -1000, Warren Togami wrote:
    >>This is a request to please merge the I2O patches currently in Andrew
    >>Morton's -mm tree into the mainline kernel. They resolve all known
    >>reported issues with I2O RAID devices. If they can be included soon, it
    >>would be possible to implement and test direct installation before FC3
    >>Test2 freeze.
    > I've looked over it and except for the i2o_scsi driver it looks sane.
    > Cosmetic fixups I'd like to see done befoee merging to mainline:
    > - run the code through Lindent

    Okay, will do it...

    > - stop the needless file renaming. Splitting up i2o_core.c into multiple
    > files is fine, but please don' rename the other drivers for the sake of
    > it

    just wanted to be consistent with the other files, but it shouldn't be a
    problem to rename them to the original name...

    > Now to i2o_scsi:
    > - the logic of "demand-allocating" Scsi_Hosts looks rather bad to me,
    > life would be much simpler with a Scsi_Host per i2o device.

    But wouldn't it be a waste of resources to allocate a Scsi_Host
    structure for every I2O device? Note that the i2o_scsi "sees" all disks
    even if they are in a RAID array, so in most cases there are at least 3
    Scsi_Host adapters...

    We also now know which disk is on which controller, this information is
    lost with your approach...

    > - the slave_configure/i2o_scsi_probe_dev logical is quite horriblebut
    > fortunately with the suggestion above it would just go away

    Yep, i know that it would be better to extend scsi_add_device, so it's
    possible to pass a pointer to i2o_scsi_slave_alloc. This is only a
    workaround, which breaks as soon as things are done in parallel :-(

    > - the global list of hosts and wlaking it on exit is a very bad design,
    > that's something the ->remove callback should do on per-device basis

    But what if the I2O device isn't removed?

    > - the completely lack of SCSI EH in this driver scares me, does the firmware
    > really handle all EH?

    The i2o_scsi driver is not used to access the disks, it is only for
    monitoring. The i2o_block driver handles disk access. So if you reset
    the SCSI channel in the i2o_scsi driver, commands which are transfered
    by the i2o_block driver will be aborted (this is the reason, why the I2O
    subsystem didn't work for users, which compiled in i2o_scsi and
    i2o_block into the kernel)...

    > cosemtic stuff in here:
    > - <asm/*.h> after <linux/*.h>.
    > - please include scsi headers using <scsi/*.h> (after linux and asm headers)
    > - please use the standard pr_Debug instead of DBG

    This is what i searched for the whole time :-) Thanks for the hint!

    > - please reorder the functions a little so you don't need forward-declarations

    most of the forward-declarations are not needed at all, should i remove
    unneeded completely?

    Thanks for taking time to review my changes!

    Best regards,

    Markus Lidel
    ------------------------------------------
    Markus Lidel (Senior IT Consultant)

    Shadow Connect GmbH
    Carl-Reisch-Weg 12
    D-86381 Krumbach
    Germany

    Phone: +49 82 82/99 51-0
    Fax: +49 82 82/99 51-11

    E-Mail: Markus.Lidel@shadowconnect.com
    URL: http://www.shadowconnect.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Premier_lotteryuk: "LOTTERY WINNING NOTIFICATION."

    Relevant Pages

    • hard disk not accessable via second ide controller
      ... I have a recently installed Debian with Linux 2.4.18-bf2.4. ... I have not yet moved any data to the 40 Gb disks. ... 00:01.0 PCI bridge: VIA Technologies, ... Serial driver version 5.05c with MANY_PORTS SHARE_IRQ ...
      (Debian-User)
    • Re: renew IP fails after system restore
      ... and disks have no descriptive labels. ... driver installed for the device there, ... got a set of system restore disks from HP and ran standard system restore ... I dont see how any files could already be corrupted as ...
      (microsoft.public.windowsxp.network_web)
    • Re: Format Hard Disk; Cant Identify Original XP Home Software
      ... > | Windows XP Home and included the OEM XP software on a CD. ... > | software disks bundled with the new computers in a drawer (along with the ... > Dell XP discs are BIOS locked to Dell computers and don't require ... > The Chipset and driver utilities found on the "Resource and Driver" CD ...
      (microsoft.public.windowsxp.perform_maintain)
    • Re: [PATCH] make ide-cd handle non-2kB sector sizes
      ... inadequate name) the driver for all ATAPI disks as opposed to ATA disks ... >> the latter, with sd, not sr being the appropriate driver. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Format Hard Disk; Cant Identify Original XP Home Software
      ... | software disks bundled with the new computers in a drawer (along with the ... Dell XP discs are BIOS locked to Dell computers and don't require ... installation purposes. ... The Chipset and driver utilities found on the "Resource and Driver" CD ...
      (microsoft.public.windowsxp.perform_maintain)