Re: [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation

From: Marcelo Tosatti (marcelo.tosatti_at_cyclades.com)
Date: 08/27/04

  • Next message: Hugh Dickins: "Re: data loss in 2.6.9-rc1-mm1" 
    Date:	Fri, 27 Aug 2004 09:03:31 -0300
To: Adrian Bunk <bunk@fs.tum.de>

    On Thu, Aug 26, 2004 at 09:54:55PM +0200, Adrian Bunk wrote:
    > I got the following compile error when trying to build 2.4.28-pre2 using
    > gcc 3.4:
    >
    > <-- snip -->
    >
    > ...
    > gcc-3.4 -D__KERNEL__
    > -I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/include -Wall
    > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
    > -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
    > -fno-unit-at-a-time -D_LINUX
    > -I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/drivers/acpi
    > -nostdinc -iwithprefix include -DKBUILD_BASENAME=ibmphp_res -c -o
    > ibmphp_res.o ibmphp_res.c
    > ibmphp_res.c: In function `ibmphp_rsrc_init':
    > ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
    > 'find_bus_wprev': function body not available
    > ibmphp_res.c:237: sorry, unimplemented: called from here
    > ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
    > 'find_bus_wprev': function body not available
    > ibmphp_res.c:261: sorry, unimplemented: called from here
    > ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
    > 'find_bus_wprev': function body not available
    > ibmphp_res.c:284: sorry, unimplemented: called from here
    > make[3]: *** [ibmphp_res.o] Error 1
    > make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/drivers/hotplug'
    >
    > <-- snip -->
    >
    >
    > The patch below fixes this issue by uninlining find_bus_wprev (as done
    > in 2.6).

    Just out of curiosity, if you move the inlined function up to the beginning of the
    file (before any calls to it), and remove the declaration (at 45), does it
    stop complaining?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Hugh Dickins: "Re: data loss in 2.6.9-rc1-mm1"