Re: [PATCH] waitid system call

From: Linus Torvalds (torvalds_at_osdl.org)
Date: 08/31/04

  • Next message: Harald Welte: "Re: [netfilter-core] 2.6.9-rc1: missing netfilter help texts" 
    Date:	Tue, 31 Aug 2004 11:26:59 -0700 (PDT)
To: Jakub Jelinek <jakub@redhat.com>

    On Tue, 31 Aug 2004, Jakub Jelinek wrote:
    >
    > Is it really necessary to check the exit code after each put_user?

    More importantly, is there really any reason to care at all?

    There's no real reason to generate extra code to check an error value that
    is pointless. It should probably just use

            (void) clear_user(infop, sizeof(*infop))

    and be done with it.

                    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Harald Welte: "Re: [netfilter-core] 2.6.9-rc1: missing netfilter help texts"

    Relevant Pages

    • Re: [PATCH] waitid system call
      ... Jakub Jelinek wrote: ... > Is it really necessary to check the exit code after each put_user? ... > is what kernel usually does when filling multiple structure members. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: zombie with CLONE_THREAD
      ... > My patch sounds much simpler to me, can you tell me what's the point of ... > leaving ptrace enabled on a task that already executed do_exit? ... How would you otherwise see what exit code the child exited with? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [HELP] How to get address of module
      ... > exit code, module_exit, etc. ... > to different sections of allocated memory. ... given the segfault address, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Git-commits mailing list feed.
      ... Matt Domsch wrote: ... Use quotes! ... The exit code should reflect the status from gpg. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] waitid system call
      ... > Is it really necessary to check the exit code after each put_user? ... > is what kernel usually does when filling multiple structure members. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)