Re: [patch] 2.6.9-rc1-mm2: char/pcxx.c doesn't compile

From: Jesper Juhl (juhl-lkml_at_dif.dk)
Date: 08/31/04

  • Next message: Christoph Hellwig: "Re: 2.6.9-rc1-mm2: why is DIGIEPCA marked BROKEN?"
    Date:	Tue, 31 Aug 2004 22:18:10 +0200 (CEST)
    To: Adrian Bunk <bunk@fs.tum.de>
    
    

    On Tue, 31 Aug 2004, Adrian Bunk wrote:

    > static void pcxxpoll(unsigned long dummy)
    > {
    > @@ -1995,6 +1982,7 @@
    > volatile struct board_chan *bc;
    > unsigned long flags;
    > int mflag = 0;
    > + int mstat;
    >
    > if(ch)
    > bc = ch->brdchan;
    > @@ -2069,6 +2057,7 @@
    > pcxxparam(tty,ch);
    > memoff(ch);
    > restore_flags(flags);
    > + return 0;
    > }

    since pcxxpoll is declared with a void return, return 0; here seems
    pointless. A simple return; or just falling off the end of the function
    should be fine as far as I can see.

    --
    Jesper Juhl <juhl-lkml@dif.dk>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Christoph Hellwig: "Re: 2.6.9-rc1-mm2: why is DIGIEPCA marked BROKEN?"

    Relevant Pages

    • [PATCH][5/6] cifs: readdir.c cleanup - avoid needless casting
      ... Explicit casts between type and void or to/from the ... same type is pointless. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [RFC] enhanced version of net_random()
      ... really thread safe, but was immune to thread corruption. ... +void net_srandom(unsigned long entropy) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.2-rc2-mm2
      ... The nfsd code does not need to check CAP_SETGID or> NGROUPS_MAX, ... Interestingly, nfsd_setuser returns void, so any error checking is moot. ... lack of any way to handle errors bothers me. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH] nmi_watchdog=2 and P4-HT
      ... If the CPU halts with local interrupts disabled (is this ... 1000 NMIs per ... void setup_apic_nmi_watchdog ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] nodemask_t ia64 changes [6/7]
      ... This is your API, so you'd probably know, but might this not end up ... Might the SLIT contain offline nodes too? ... -extern void setup_replication_mask; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)