[3/2] document wake_up_bit()'s requirement for preceding memory barriers
From: William Lee Irwin III (wli_at_holomorphy.com)
Date: 08/31/04
- Previous message: Frank van Maarseveen: "Re: silent semantic changes with reiser4"
- In reply to: William Lee Irwin III: "[2/2] reduce number of parameters to __wait_on_bit() and __wait_on_bit_lock()"
- Next in thread: Andrew Morton: "Re: 2.6.9-rc1-mm2 : compilation error in kernel/wait.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 31 Aug 2004 14:12:34 -0700 To: Andrew Morton <akpm@osdl.org>
On Tue, Aug 31, 2004 at 02:05:42PM -0700, William Lee Irwin III wrote:
> Some of the parameters to __wait_on_bit() and __wait_on_bit_lock() are
> redundant, as the wait_bit_queue parameter holds the flags word and the
> bit number. This patch updates __wait_on_bit() and __wait_on_bit_lock()
> to fetch that information from the wait_bit_queue passed to them and so
> reduce the number of parameters so that -mregparm may be more effective.
> Incremental atop the complete out-of-lining of the contention cases and
> the fastcall and wait_on_bit_lock()/test_and_set_bit() fixes.
> Successfully tested on x86-64.
Document the requirement to use a memory barrier prior to wake_up_bit().
Index: mm2-2.6.9-rc1/kernel/wait.c
===================================================================
--- mm2-2.6.9-rc1.orig/kernel/wait.c 2004-08-31 02:00:10.000000000 -0700
+++ mm2-2.6.9-rc1/kernel/wait.c 2004-08-31 14:07:13.688481360 -0700
@@ -219,6 +219,13 @@
* is the part of the hashtable's accessor API that wakes up waiters
* on a bit. For instance, if one were to have waiters on a bitflag,
* one would call wake_up_bit() after clearing the bit.
+ *
+ * In order for this to function properly, as it uses waitqueue_active()
+ * internally, some kind of memory barrier must be done prior to calling
+ * this. Typically, this will be smp_mb__after_clear_bit(), but in some
+ * cases where bitflags are manipulated non-atomically under a lock, one
+ * may need to use a less regular barrier, such fs/inode.c's smp_mb(),
+ * because spin_unlock() does not guarantee a memory barrier.
*/
void fastcall wake_up_bit(void *word, int bit)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Frank van Maarseveen: "Re: silent semantic changes with reiser4"
- In reply to: William Lee Irwin III: "[2/2] reduce number of parameters to __wait_on_bit() and __wait_on_bit_lock()"
- Next in thread: Andrew Morton: "Re: 2.6.9-rc1-mm2 : compilation error in kernel/wait.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
