Re: Driver retries disk errors.

From: Bill Davidsen (davidsen_at_tmr.com)
Date: 09/01/04

  • Next message: K.R. Foley: "Re: [patch] voluntary-preempt-2.6.9-rc1-bk4-Q7" 
    Date:	Wed, 1 Sep 2004 14:54:28 -0400 (EDT)
To: Alan Cox <alan@lxorguk.ukuu.org.uk>

    On Wed, 1 Sep 2004, Alan Cox wrote:

    > On Mer, 2004-09-01 at 16:18, Bill Davidsen wrote:
    > > If would probably be good to retry "read what you were asked, nothing
    > > more" on error, to avoid passing back errors caused by readahead. I
    > > suspect this would avoid some issues reading data off CD as well, where
    > > one software can read clean and another ends with a short image and error.
    >
    > Sure but as I understand the block layer currently (and I may be missing
    > something in the 2.6 code) I can't do that from a driver.
    >
    Sorry, that was unclear. I was speaking of a general approach rather than
    what would be done in the driver. Clearly that's best done at a higher
    level. Drivers should not be making policy decisions of that type, but I
    don't think it's good to return a read error caused by data the program
    didn't request (ie. readahead).

    Unless S.M.A.R.T is lying, that happens so seldom on disk that the
    overhead of a retry doesn't matter. And on CD it makes things work where
    currently they fail. 

    -- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: K.R. Foley: "Re: [patch] voluntary-preempt-2.6.9-rc1-bk4-Q7"

    Relevant Pages

    • Re: [patch] kernel events layer
      ... > messages get stuck somewhere common so driver writes can't add these ... > ad-hoc and we can avoid a proliferation of either similar or pointless ... This is a good idea for other reasons, too: the common base of errors ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • rtl8150.c ethernet driver : usb_unlink_urb ->usb_kill_urb
      ... While we are looking at this driver, here is a way to avoid one full ... page of annoying messages at shutdown/module unload. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.4] forcedeth
      ... > Any chance to give the driver a more descriptive name, ... I would prefer to avoid the issue completely, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: My thoughts on the "new development model"
      ... |>>> 2.6 tree is great for gentoo users who like gcc consuming all CPU ... |>> that after a month or so of fixes etc it will be a very stable kernel ... driver for 2.6.7 for an ADSL card; a development driver for 2.6.5 for a ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: sata related hang with linux-2.6
      ... IMHO there's something not quite right with the Silicon Image libata ... Perhaps the driver is enabling the hardware to generate interrupts ... before setting up the interrupt routine for it? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)