[patch 04/14] radio/radio-aimslab: replace while/schedule() with msleep()

janitor_at_sternwelten.at
Date: 09/02/04

  • Next message: Roland Dreier: "Re: f_ops flag to speed up compatible ioctls in linux kernel"
    To: akpm@osdl.org
    Date:	Thu, 02 Sep 2004 01:16:00 +0200
    
    

    I would appreciate any comments from the janitor@sternweltens list.

    Thanks,
    Nish

    Description: Uses msleep() instead of a while-loop and schedule(). Thus
    the CPU is given up for the time desired.

    Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
    Signed-off-by: Maximilian Attems <janitor@sternwelten.at>

    ---
     linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-aimslab.c |    7 +------
     1 files changed, 1 insertion(+), 6 deletions(-)
    diff -puN drivers/media/radio/radio-aimslab.c~msleep-drivers_media_radio-aimslab drivers/media/radio/radio-aimslab.c
    --- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-aimslab.c~msleep-drivers_media_radio-aimslab	2004-09-01 19:35:10.000000000 +0200
    +++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-aimslab.c	2004-09-01 19:35:10.000000000 +0200
    @@ -63,12 +63,7 @@ static void sleep_delay(long n)
     	if(!d)
     		udelay(n);
     	else
    -	{
    -		/* Yield CPU time */
    -		unsigned long x=jiffies;
    -		while((jiffies-x)<=d)
    -			schedule();
    -	}
    +		msleep(jiffies_to_msecs(d));
     }
     
     static void rt_decvol(void)
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Roland Dreier: "Re: f_ops flag to speed up compatible ioctls in linux kernel"

    Relevant Pages

    • [PATCH] RCU - cpu-offline-cleanup [1/3]
      ... There is a series of patches in my tree and these 3 are the first ... Minor cleanup of the hotplug code to remove #ifdef in cpu ... +static void rcu_offline_cpu ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH linux-2.6-block:post-2.6.15 04/10] blk: update SCSI to use new blk_ordered
      ... static void sd_rescan ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH linux-2.6-block:post-2.6.15 04/11] blk: update SCSI to use new blk_ordered
      ... static void sd_rescan ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [RFC, PATCH] 4/5 rcu lock update: Hide locking details
      ... Clear it from the cpu mask and complete the grace period if it was the last ... +static void cpu_quiet ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • (no subject)
      ... Subject: Re: CPU hot-plug support for x86_64 ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - ...
      (Linux-Kernel)