[patch] 2.6.9-rc1-mm3: cdrom/cdu31a.c doesn't compile

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 09/04/04

  • Next message: Anton Blanchard: "[PATCH] fix oprofile vfree warning on error"
    Date:	Sat, 4 Sep 2004 19:52:56 +0200
    To: Andrew Morton <akpm@osdl.org>, Nishanth Aravamudan <nacc@us.ibm.com>, Maximilian Attems <janitor@sternwelten.at>
    
    

    On Fri, Sep 03, 2004 at 01:48:11AM -0700, Andrew Morton wrote:
    >...
    > Changes since 2.6.9-rc1-mm2:
    >...
    > +cdu31a-replace-schedule_timeout-with-msleep.patch
    >...
    > Janitorial things
    >...

    Doesn't compile:

    <-- snip -->

    ...
      CC drivers/cdrom/cdu31a.o
    drivers/cdrom/cdu31a.c: In function `do_sony_cd_cmd':
    drivers/cdrom/cdu31a.c:962: parse error before `:'
    drivers/cdrom/cdu31a.c:932: warning: label `retry_cd_operation' defined but not used
    make[2]: *** [drivers/cdrom/cdu31a.o] Error 1

    <-- snip -->

    Trivial fix:

    Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

    --- linux-2.6.9-rc1-mm3-full/drivers/cdrom/cdu31a.c.old 2004-09-04 11:30:21.000000000 +0200
    +++ linux-2.6.9-rc1-mm3-full/drivers/cdrom/cdu31a.c 2004-09-04 11:31:08.000000000 +0200
    @@ -959,7 +959,7 @@
             if (((result_buffer[0] & 0xf0) == 0x20)
                 && (num_retries < MAX_CDU31A_RETRIES)) {
                     num_retries++;
    - msleep(100):
    + msleep(100);
                     goto retry_cd_operation;
             }
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Anton Blanchard: "[PATCH] fix oprofile vfree warning on error"

    Relevant Pages

    • Typo in bttv-driver.c in versions 2.4.21 to 2.4.23
      ... - Which gives a parse error when one tries to compile. ... A search on google showed that the bug was already documented by Kyle ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Possible dcache BUG
      ... During the compile, the above line output this warning: ... Copyright 2004 by Maurice Eugene Heskett, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux GPL and binary module exception clause?
      ... of them for every exported symbol in turn, ... hacked -E:) we don't need to compile for this, ... `...some suburbanite DSL customer who thinks kernel patches are some ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch, 2.6.10-rc2] sched: fix ->nr_uninterruptible handling bugs
      ... > it, run lmbench, then compile a SMP kernel, and run it again. ... The Athlon64 really shines doing atomic ops though, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Compiling cardbus devices monolithic doesnt work?
      ... I should compile a monolithic 2.4 kernel and see what it does...) ... > IIRC hermes provides the low level interface to the device, ... > provides a bridge between the PCMCIA subsystem and orinoco. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)