RE: 2.4.28-pre3: broken ips update
From: Arjan van de Ven (arjanv_at_redhat.com)
Date: 09/13/04
- Previous message: Matthew Wilcox: "Re: 2.4.28-pre3: broken ips update"
- In reply to: Hammer, Jack: "RE: 2.4.28-pre3: broken ips update"
- Next in thread: Mikael Pettersson: "Re: 2.4.28-pre3: broken ips update"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: "Hammer, Jack" <Jack_Hammer@adaptec.com> Date: Mon, 13 Sep 2004 16:46:25 +0200
On Mon, 2004-09-13 at 16:28, Hammer, Jack wrote:
> Marcelo,
> --- linux.orig/drivers/scsi/ips.h Mon Sep 13 09:40:04 2004
> +++ linux/drivers/scsi/ips.h Mon Sep 13 09:40:27 2004
> @@ -97,7 +97,7 @@
>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>
> - #ifndef irqreturn_t
> + #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,23)
> typedef void irqreturn_t;
> #endif
>
your fix is wrong.
you should nuke all version codes, and ONLY ifndef for IRQ_NONE and
nothing else. That's not just cosmetics, that's also to make keep
working with those exact vendor kernels you claim to have tested on :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- application/pgp-signature attachment: This is a digitally signed message part
- Previous message: Matthew Wilcox: "Re: 2.4.28-pre3: broken ips update"
- In reply to: Hammer, Jack: "RE: 2.4.28-pre3: broken ips update"
- Next in thread: Mikael Pettersson: "Re: 2.4.28-pre3: broken ips update"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
