Re: [patch] voluntary-preempt-2.6.9-rc2-mm3-S5

From: K.R. Foley (kr_at_cybsft.com)
Date: 09/24/04

  • Next message: Geert Uytterhoeven: "Re: unresolved symbol __udivsi3_i4"
    Date:	Fri, 24 Sep 2004 06:05:52 -0500
    To: Ingo Molnar <mingo@elte.hu>
    
    

    Ingo Molnar wrote:
    > * K.R. Foley <kr@cybsft.com> wrote:
    >
    >
    >>The following, on top of Ingo's patch above, fixes the problem with
    >>dropping new connections and doesn't have any adverse affects that
    >>I've seen:
    >>
    >>--- linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c.orig 2004-09-23
    >>22:16:42.249435870 -0500
    >>+++ linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c 2004-09-23
    >>22:12:03.911811945 -0500
    >>@@ -699,11 +699,6 @@
    >>
    >> tcp_minshall_update(tp, mss_now, skb);
    >> sent_pkts = 1;
    >>- /*
    >>- * Break out early - we'll continue later:
    >>- */
    >>- if (softirq_need_resched())
    >>- break;
    >
    >
    > hm, ok, i'll revert this in my tree. I suspect we'll see some latencies
    > resurfacing under high network load again, but correctness goes first
    > obviously. If then we'll have to find some other method to break that
    > critical path.
    >
    > Ingo
    >
    Ingo,

    Maybe this wasn't the right way to fix the problem? I just looked at the
    S4 patch and it had the same change in it, but did not exhibit the same
    problem. Not knowing exactly what I was looking for, I just started
    looking for obvious changes that might affect dropping tcp connections
    and this one seemed reasonable. I made the change and the problem went
    away. Maybe this needs looking at a little closer.

    kr
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Geert Uytterhoeven: "Re: unresolved symbol __udivsi3_i4"

    Relevant Pages

    • Re: [Fwd: Re: 3 connections as one]
      ... Another option has been added to natd, a number wich can be set from 0 to ... 100 to determine the use of the second alias address. ... So when a connection has to be established for the first time, the patch use ... So natd is generating new connections in two diferent IPs (for two diferent ...
      (freebsd-hackers)
    • Re: IPFW and IPv6 TCP timeout problem
      ... TCP connections after a short timeout. ... Luigi Rizzo about it but he cannot help with the IPv6 part of the ipfw. ... The PR includes a patch, it just needs somebody to commit it. ...
      (freebsd-net)
    • Re: IPTables Problem: I think I figured it out... [was IPTables Established connection Problem]
      ... >> So my server was dropping those connections. ... > Out of interest, and a slightly voodoo suggestion, does dropping your MTU ... I'm sure conntrack is not the problem here. ... If it is a very high traffic link you may want to add a filter to only ...
      (comp.os.linux.security)
    • Re: T5xxx servers short "freeze" behaviour
      ...  machine is freezing for a couple of secconds and then continues ... That patch didn't fix my problem. ... is poking ping, http, https, drupal, etc, and I see alerts from Common ... Array Manager claiming to have lost iSCSI connections. ...
      (comp.unix.solaris)
    • [Full-Disclosure] The remote Openssh User-Level-Denial-Of-Service
      ... A flawless into connections management and keys handshake was discovered into ... OpenSSH 3.8p1 ... user can open MAX connections to the server's daemon, ... Apply the patch or wait for an official patch from openssh. ...
      (Full-Disclosure)