[patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod
From: John W. Linville (linville_at_tuxdriver.com)
Date: 09/28/04
- Previous message: Arjan van de Ven: "Re: heap-stack-gap for 2.6"
- Next in thread: Donald Becker: "Re: [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod"
- Reply: Donald Becker: "Re: [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 28 Sep 2004 14:54:55 -0400 To: akpm@osdl.org
Some (earlier?) versions of the 3c905(B) card get confused and refuse to
work again after the 3c59x module is removed (even after reloading the
module). Changing vortex_remove_one() to allow the auto-initialize
state machine logic to be reset when the module is removed alleviates
this problem.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
See http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=133388 for more
details.
If anyone can suggest a better way to fix this problem, please do so.
I'll be happy to pursue it.
drivers/net/3c59x.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
This patch should apply (with a little fuzz) to 2.4 as well...
--- linux-2.6/drivers/net/3c59x.c.orig
+++ linux-2.6/drivers/net/3c59x.c
@@ -3162,7 +3162,7 @@ static void __devexit vortex_remove_one
pci_restore_state(VORTEX_PCI(vp), vp->power_state);
}
/* Should really use issue_and_wait() here */
- outw(TotalReset|0x14, dev->base_addr + EL3_CMD);
+ outw(TotalReset|0x04, dev->base_addr + EL3_CMD);
pci_free_consistent(pdev,
sizeof(struct boom_rx_desc) * RX_RING_SIZE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Arjan van de Ven: "Re: heap-stack-gap for 2.6"
- Next in thread: Donald Becker: "Re: [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod"
- Reply: Donald Becker: "Re: [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
