Re: [PATCH 2.6.8.1] drivers/char: New serial driver.
From: Christoph Hellwig (hch_at_infradead.org)
Date: 09/28/04
- Previous message: Kilau, Scott: "RE: [PATCH 2.6.8.1] drivers/char: New serial driver."
- In reply to: Kilau, Scott: "[PATCH 2.6.8.1] drivers/char: New serial driver."
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 28 Sep 2004 21:16:02 +0100 To: "Kilau, Scott" <Scott_Kilau@digi.com>
On Mon, Sep 27, 2004 at 03:03:32PM -0500, Kilau, Scott wrote:
> I am submitting a new serial driver for the 2.6 series of kernels.
>
> Description:
> Digi serial driver for the Digi Neo and Classic PCI serial port
> products.
- you pci handling is rather bogus. You must handle all initialization
from ->probe and all teardown from ->remove. No fuzzing with board
count please - if pci_module_init returned success the driver must
stay loaded
- why is this one driver and not two? Please split it into one driver
for each hardware type
- the procfs/sysctl support is rather gross. For sysctl please use
simple tabls like everyone else (e.g. look at fs/xfs/linux-2.6/xfs_systl.c)
Also new procfs entries are discouraged in general, but if you absolutely
need them use the fs/seq_file.c interface
- please convert to Russell's serial_core interface (drivers/serial),
we already have far more copies of the old serial driver munged into
various driver than nessecary
- if you want compat code please always emulted older apis on old
ones.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Kilau, Scott: "RE: [PATCH 2.6.8.1] drivers/char: New serial driver."
- In reply to: Kilau, Scott: "[PATCH 2.6.8.1] drivers/char: New serial driver."
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
