Re: New DRM driver model - gets rid of DRM() macros!
From: Christoph Hellwig (hch_at_infradead.org)
Date: 09/29/04
- Previous message: Jon Smirl: "Re: vga class / drm patch"
- In reply to: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Next in thread: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Reply: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 29 Sep 2004 15:16:01 +0100 To: Keith Whitwell <keith@tungstengraphics.com>
On Wed, Sep 29, 2004 at 03:12:03PM +0100, Keith Whitwell wrote:
> Thinking about it, it may not have been a problem of crashing, but rather that
> the behaviour visible from a program attempting to read (or poll) was
> different with noop versions of these functions to NULL versions, and that was
> causing problems. This is 18 months ago, so yes, I'm being vague.
>
> The X server does look at this file descriptor, which is where the problem
> would have arisen, but only the gamma & maybe ffb drivers do anything with it.
Indeed, for read you're returning 0 now instead of the -EINVAL from common
code when no ->read is present. I'd say the current drm behaviour is a bug,
but if X drivers rely on it.
Similar in poll your return 0 now while the generic code return
(POLLIN | POLLOUT | POLLRDNORM | POLLWRNORM) for fds without ->poll, and
again I'd say current drm behaviour could be considered a bug.
for ->flush there's no behaviour change of not supplying it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jon Smirl: "Re: vga class / drm patch"
- In reply to: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Next in thread: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Reply: Keith Whitwell: "Re: New DRM driver model - gets rid of DRM() macros!"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
