Re: [ACPI] [PATCH] Updated patches for PCI IRQ resource deallocation support [2/3]

From: Zwane Mwaikambo (zwane_at_linuxpower.ca)
Date: 09/29/04

  • Next message: James Bottomley: "Re: [Patch] Fix oops on rmmod usb-storage" 
    Date:	Wed, 29 Sep 2004 18:13:44 +0300 (EAT)
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

    On Wed, 29 Sep 2004, Kenji Kaneshige wrote:

    > I'm trying to update my patch based on the feedback from you. Updated
    > patch defines acpi_unregister_gsi() in both include/asm-i386/acpi.h
    > and include/asm-ia64/acpi.h. But now I'm having one concern about it.
    >
    > Some arch specific functions would be called from acpi_unregister_gsi()
    > when it is implemented. But include/asm-xxx/acpi.h is included before
    > many other header files, so many 'implicit declaration of function xxx'
    > warning message would be appeared. These warning messages are disappeared
    > if we declare all functions called by acpi_unregister_gsi() also in
    > include/asm-xxx/acpi.h. But I don't like this approach very much.
    >
    > After all, now I think it is better not to define acpi_unregister_gsi()
    > in header files.

    Ok i think i may have not conveyed my meaning properly, my mistake. What i
    think would be better is if the architectures which have no-op
    acpi_unregister_gsi to declare them as static inline in header files. For
    architectures (such as ia64) which have a functional acpi_unregister_gsi,
    we can declare them in a .c file with the proper exports etc.

    Thanks Kenji and sorry for the confusion.
            Zwane

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: James Bottomley: "Re: [Patch] Fix oops on rmmod usb-storage"

    Relevant Pages

    • Re: How to Define a global const class variable in MFC?
      ... but in vc++ it seems that we have to both declare and define variables in ... would declare an array of fixed size in C++ escapes me...). ... I can write the whole header files and source files but I thought it will be ... declarations are so we can figure out why the error message, that SPECIFIC error message, ...
      (microsoft.public.vc.mfc)
    • Re: checking array indices
      ... but we can't tell about>99 unless you declare C as ... Using assert is fine when you are developing and testing, ... Note also that assertwill not just generate a warning message; ... Boeing Associate Technical Fellow ...
      (comp.lang.c)
    • Re: [ACPI] [PATCH] Updated patches for PCI IRQ resource deallocation support [2/3]
      ... I'm trying to update my patch based on the feedback from you. ... many other header files, so many 'implicit declaration of function xxx' ... warning message would be appeared. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Structure of MFC
      ... You declare the variables where they are needed. ... You initialize them at the point where it ... It's just programming. ... put them in header files you create. ...
      (microsoft.public.vc.mfc)
    • Re: Std Map .. Help
      ... This is a valid header file, but it doesn't declare the std::string class ... Use <string> instead ... You need to use the correct header files (no C++ header files have .h in ...
      (comp.lang.cpp)