PATCH: minor IDE clean up I noticed

From: Alan Cox (alan_at_redhat.com)
Date: 09/30/04

  • Next message: Alan Cox: "PATCH: Fix up tty patch problem with pc300 and clean up braces" 
    Date:	Thu, 30 Sep 2004 13:54:30 -0400
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org

    Nowdays a drive always has a driver

    diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c linux-2.6.9rc3/drivers/ide/ide-proc.c
    --- linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 15:35:48.169975152 +0100
    +++ linux-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 16:33:46.423200288 +0100
    @@ -365,20 +365,7 @@
             {
                     unsigned short *val = (unsigned short *) page;
                     
    - /*
    - * The current code can't handle a driverless
    - * identify query taskfile. Now the right fix is
    - * to add a 'default' driver but that is a bit
    - * more work.
    - *
    - * FIXME: this has to be fixed for hotswap devices
    - */
    -
    - if(DRIVER(drive))
    - err = taskfile_lib_get_identify(drive, page);
    - else /* This relies on the ID changes */
    - val = (unsigned short *)drive->id;
    -
    + err = taskfile_lib_get_identify(drive, page);
                     if(!err)
                     {
                             char *out = ((char *)page) + (SECTOR_WORDS * 4);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Alan Cox: "PATCH: Fix up tty patch problem with pc300 and clean up braces"

    Relevant Pages