Re: [PATCH 2.6] Natsemi - remove compilation warnings

From: Andrey S. Klochko (aklochko_at_acipower.com)
Date: 09/30/04

  • Next message: Jon Smirl: "Re: New DRM driver model - gets rid of DRM() macros!" 
    Date:	Thu, 30 Sep 2004 14:09:28 -0400
To: Linus Torvalds <torvalds@osdl.org>

    Linus Torvalds wrote:
    >
    > * One readl should be good to PCI @ 100MHz
    > */
    > -#define mii_delay(dev) readl(dev->base_addr + EECtrl)
    > +#define mii_delay(dev) readl(ioaddr + EECtrl)
                          ^^^
    Probably this should be
    +#define mii_delay(ioaddr) readl(ioaddr + EECtrl)

    and than change all occurrences of
    mii_delay(dev) to mii_delay(ioaddr)
    ?
    > static int mii_getbit (struct net_device *dev)
    > {

    Thanks,

    Andrey

    -----------
    Andrey Klochko
    System Administrator
    Applied Concepts, Inc.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jon Smirl: "Re: New DRM driver model - gets rid of DRM() macros!"