Re: 2.6.9-rc2-mm4 e100 enable_irq unbalanced from

From: Jeremy Fitzhardinge (jeremy_at_goop.org)
Date: 09/30/04

  • Next message: Linus Torvalds: "Re: [PATCH 2.6] Natsemi - remove compilation warnings" 
    To: Paul Fulghum <paulkf@microgate.com>
Date:	Thu, 30 Sep 2004 11:21:46 -0700

    On Mon, 2004-09-27 at 16:12 -0500, Paul Fulghum wrote:
    > On Mon, 2004-09-27 at 14:24, Paul Fulghum wrote:
    > > The e100 module is generating a warning:
    > >
    > > Sep 27 13:30:29 deimos kernel: e100: Intel(R) PRO/100 Network Driver, 3.1.4-NAPI
    > > Sep 27 13:30:29 deimos kernel: e100: Copyright(c) 1999-2004 Intel Corporation
    > > Sep 27 13:30:29 deimos kernel: e100: eth0: e100_probe: addr 0xfecfc000, irq 16, MAC addr 00:90:27:3A:C5:E3
    > > Sep 27 13:30:29 deimos kernel: enable_irq(16) unbalanced from ec83ff33
    > > Sep 27 13:30:29 deimos kernel: [<c010923f>] enable_irq+0xcf/0xe0
    > > Sep 27 13:30:29 deimos kernel: [<ec83ff33>] e100_up+0xf3/0x1f0 [e100]
    >
    > The following patch works for me and removes the warning.
    >
    > The disable_irq/enable_irq is not needed because
    > the ISR can't be called before calling request_irq,
    > the hardware is initialized before calling request_irq,
    > and request_irq itself enables the interrupt if needed.
    >
    > Comments?

    Hi,

    That change was my fault, to address a problem with doing a resume from
    suspend. The e100 in my laptop seems to emit a spurious interrupt on
    resume, and the intention was to block interrupts until the handler had
    been installed - otherwise I get a "got interrupt X and nobody cared"
    message.

    While this works for me (probably because IRQ11 is heavily shared), it's
    apparently pretty bogus. But it did achieve the goal of getting the
    problem looked at...

            J

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Linus Torvalds: "Re: [PATCH 2.6] Natsemi - remove compilation warnings"

    Relevant Pages

    • Re: Interrupt Handling in linux
      ... im developing a driver for and ... > timer interrupt comes in. ... > spinlocks or other mechanisms in our ISR, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PCI lost interrupts and PLX chips
      ... No interrupt at /proc/interrupts. ... The ISR never gets called. ... > before the device was enabled, the ISR writes 0 to the PLX CSR after ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Baycon
      ... It is an invasive interrupt at *best*. ... got the wit to recognise that calling when wageearners are likely to be ... It is still a demand for attention, ... few people I can call without feeling stress about it, ...
      (rec.arts.sf.composition)
    • Re: Forth as an operating system
      ... I consider preemptive multitasking to be a bit ... calling upon an ISR to service an interrupt. ... One possible confusion may be coming from how some preemptive systems will use tasks to handle the interrupt. ... the ISR routine does little more than signal the scheduler to run a task for handling the interrupt. ...
      (comp.lang.forth)
    • Re: More bad opperating procedure...
      ... I know the band plan... ... I never call break...I always interrupt using my callsign... ... I would never operate 12.5kc from the calling frequency...not even just to ... > and your crappy radio, with its barn door front end, was failing you badly ...
      (uk.radio.amateur)