Re: Serial driver hangs

From: Paul Fulghum (paulkf_at_microgate.com)
Date: 09/30/04

  • Next message: Alan Cox: "Re: PATCH: (Test) it8212 driver for 2.6.9rc3"
    To: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Date:	Thu, 30 Sep 2004 16:25:04 -0500
    
    

    On Thu, 2004-09-30 at 15:10, Alan Cox wrote:
    > On Iau, 2004-09-30 at 21:30, Paul Fulghum wrote:
    > > tty->flip.work.func and tty->flip.tqueue.routine
    > > are set to flush_to_ldisc()
    >
    > flush_to_ldisc was ok, then someone added the low latency
    > flag. In the current 2.6.9rc3 patch flush_to_ldisc honours
    > TTY_DONT_FLIP also

    In the cases I described the low latency flag
    does not come into play because flush_to_ldisc()
    is called directly instead of
    through tty_flip_buffer_push().

    TTY_DONT_FLIP is only set in read_chan().
    If read_chan() is not running, TTY_DONT_FLIP is not
    set and does not prevent buffers from flipping
    if the ISR calls flush_to_ldisc() directly
    while ldisc->receive_buf() is running.

    The answer seems to be: don't call
    flush_to_ldisc directly like the current
    serial driver does.

    -- 
    Paul Fulghum
    paulkf@microgate.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Alan Cox: "Re: PATCH: (Test) it8212 driver for 2.6.9rc3"

    Relevant Pages

    • RE: RFD: Kernel release numbering
      ... What I have in mind is that we have a ... real 2.6 stable release maintainer. ... Alan Cox ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: log-buf-len dynamic
      ... Centralized systems like CVS are child's play. ... I'm using the Linux VM. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: elvtune with 2.6 kernels (under FC3)
      ... > I am cc-ing this to the kernel list, a i have the suspicion that it may ... but at least you can play. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: log-buf-len dynamic
      ... you also asked us to giveup the freedom of ... Centralized systems like CVS are child's play. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.4.28-pre4-bk6] delkin_cb: new driver for Cardbus IDE CF adaptor
      ... Alan Cox wrote: ... ide-cs does seem to be reliable, ... (hdparm keeper & the original "Linux IDE Guy") ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)