[patch] inotify: ioctl makeover

From: Robert Love (rml_at_ximian.com)
Date: 09/30/04

  • Next message: D. Stimits: "kernel oops 2.6.8 SMP"
    To: John McCutchan <ttb@tentacle.dhs.org>
    Date:	Thu, 30 Sep 2004 17:36:53 -0400
    
    
    

    Attached patch greatly cleans up inotify's ioctl method. Oh my.

    Net loss of 36 lines.

    Main thing is removing all of the access_ok() checks and _IOC macros.
    We don't need them. We can just fall off the end of the switch and
    return -EINVAL if the cmd does not match. Any other access control is
    handled by the device node itself or the copy_from_user() calls.

    Also, other misc. changes.

    Patch is on top of 0.11.0.

    Best,

            Robert Love

    
    

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/



  • Next message: D. Stimits: "kernel oops 2.6.8 SMP"

    Relevant Pages

    • Re: [RFC: 2.6 patch] drivers/ieee1394/pcilynx.c: remove dead options
      ... > Is this patch for removing them and the code behind them correct, ... > Read honest & candid reviews on hundreds of IT Products from real users. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.7-bk way too fast
      ... > Neither the first one or removing the line fixes it. ... my one-liner patch won't have applied at all if you had applied ... enable APIC debugging in include/asm-i386/apic.h, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: As of 2.6.13-rc1 Fusion-MPT very slow
      ... removing those it compiles fine. ... This patch also solves my problem, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Recursion bug in -rt
      ... the new patch is available at ... So IMO the above check is not right. ... However removing this check ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH] better locking in fs/proc/generic.c (bug 1552)
      ... > adding and removing /proc entries. ... Andrew posted a one-liner patch there which was ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)