Re: [RFC][PATCH] Way for platforms to alter built-in serial ports
From: Benjamin Herrenschmidt (benh_at_kernel.crashing.org)
Date: 10/01/04
- Previous message: Andrew Morton: "Re: [PATCH] Revert mistakenly applied patch to sungem"
- Next in thread: Bjorn Helgaas: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Reply: Bjorn Helgaas: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Maybe reply: Russell King: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Maybe reply: Russell King: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Bjorn Helgaas <bjorn.helgaas@hp.com> Date: Fri, 01 Oct 2004 09:53:30 +1000
On Fri, 2004-10-01 at 02:14, Bjorn Helgaas wrote:
> This looks like a reasonable short-term fix, but I think the whole
> serial8250_isa_init_ports() should go away. I like dwmw2's suggestion
> of an 8250_platform.c that could use register_serial() for each port
> in some platform-supplied old_serial_port[] table, which is probably
> what you mean by moving to a more dynamic allocation.
What would this file look like ? a bunch of platform #ifdef's with
different implementations each time ?
> AFAICS, the only reason for doing serial8250_isa_init_ports() early
> is for early serial consoles, and I think those should be done along
> the lines of this:
> http://www.ussg.iu.edu/hypermail/linux/kernel/0409.1/1034.html
> where the platform can specify a device by its MMIO or IO port address,
> and we automatically switch to the corresponding ttyS device later.
Eventually...
In the meantime, that patch would fix urgent problems for ppc now so
I'd appreciate if Russell would consider it for inclusion asap. This
is the kind of subject on which everybody comes up with a different
"better" way to do it and no code, and nothign ever gets implemented
and we end up with no progress...
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Andrew Morton: "Re: [PATCH] Revert mistakenly applied patch to sungem"
- Next in thread: Bjorn Helgaas: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Reply: Bjorn Helgaas: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Maybe reply: Russell King: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Maybe reply: Russell King: "Re: [RFC][PATCH] Way for platforms to alter built-in serial ports"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
